refactor: drop openmmlab package deps from train/test workflows#1128
Draft
GeorgePearse wants to merge 2 commits intomainfrom
Draft
refactor: drop openmmlab package deps from train/test workflows#1128GeorgePearse wants to merge 2 commits intomainfrom
GeorgePearse wants to merge 2 commits intomainfrom
Conversation
Contributor
|
✅ Skylos Scan: No dead code or security issues detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mmcv,mmdet, andmmenginefrom active train/test entrypointstools/train.pyandtools/test.pyto use visdet-native config/runner flowsscripts/test_presets_simple.py,scripts/test_yaml_simple.py)mmdet -> visdetmmdet -> visdetscripts/test_yaml_config.py--outputWhy
This repository should not require the external OpenMMLab packages for supported workflows. The key user-facing train/test entrypoints now run on visdet-native code only.
Validation
uv run python -m py_compile tools/train.py tools/test.py scripts/generate_model_zoo.py visdet/engine/model/utils.py visdet/engine/utils/dl_utils/misc.pyuv run python tools/train.py --helpuv run python tools/test.py --helpuv run pytest -v --tb=short77 passed, 45 skipped, 0 failedimport/from mmcv|mmdet|mmengineremainsNotes
tools/codediff/tests/test_parser.pystill containsmmcv/mmengineimport strings as fixture text for normalization tests; it does not import those packages at runtime.