Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps electron from 33.2.1 to 34.0.0.

Release notes

Sourced from electron's releases.

electron v34.0.0

Release Notes for v34.0.0

Stack Upgrades

Breaking Changes

  • Made menu bar hidden on fullscreen in Windows. #43402

Features

Additions

  • Added APIs to manage shared dictionaries for compression efficiency using Brotli or ZStandard. The new APIs are session.getSharedDictionaryUsageInfo(), session.getSharedDictionaryInfo(options), session.clearSharedDictionaryCache(), and session.clearSharedDictionaryCacheForIsolationKey(options). #44950 (Also in 33)
  • Added WebFrameMain.collectJavaScriptCallStack() for accessing the JavaScript call stack of unresponsive renderers. #44938 (Also in 33)
  • Added WebFrameMain.detached for frames in an unloading state.
    • Added WebFrameMain.isDestroyed() to determine if a frame has been destroyed.
    • Fixed webFrameMain.fromId(processId, frameId) returning a WebFrameMain instance which doesn't match the given parameters when the frame is unloading. #43473 (Also in 33)
  • Added error event in utility process to support diagnostic reports on V8 fatal errors. #43774 (Also in 33)
  • Added support for the macOS system picker in desktopCapturer and setDisplayMediaRequestHandler. #43581 (Also in 32, 33)
  • Feat: GPU accelerated shared texture offscreen rendering. #42953 (Also in 33)

Improvements

  • Performance improvements when processing microtasks. #44471 (Also in 32, 33)

Fixes

  • Fixed file chooser dialogs for flaptak applications. #44681
  • Fixed issue where 'contextmenu' event is emitted twice on macOS. #44997

Also in earlier versions...

  • Fixed BrowserView auto resize issue. #43463 (Also in 31, 32, 33)
  • Fixed MenuItem.click handler not setting focusedWindow parameter when focused window is a BaseWindow. #43404 (Also in 31, 32, 33)
  • Fixed chrome.i18n extension API being unavailable in service workers. #45036 (Also in 31, 32, 33)
  • Fixed trace-startup not working on macOS. #44275 (Also in 32, 33)
  • Fixed a build failure when the enable_plugins build flag is false. #44003 (Also in 33)
  • Fixed a crash that could occur when calling shell.readShortcutLink on Windows. #44804 (Also in 33)
  • Fixed a crash when calling focus on a WebView's webContents. #43921 (Also in 31, 32, 33)
  • Fixed a potential issue accessing a child window document when overriding browserWindow creation via setWindowOpenHandler. #43775 (Also in 31, 32, 33)
  • Fixed a potential issue with fillable PDF forms saving correctly in some circumstances. #43667 (Also in 31, 32, 33)
  • Fixed an issue when dragging to resize when using Window Controls Overlay on Linux. #43724 (Also in 31, 32, 33)
  • Fixed an issue where BaseWindow.setTouchBar didn't work as expected. #43353 (Also in 30, 31, 32, 33)
  • Fixed an issue where EventSource was undefined in both renderer and worker processes when Node.js integration was enabled. #44495 (Also in 32, 33)
  • Fixed an issue where WebContentsViews did not show correctly in some circumstances on macOS after being added as child views. #43638 (Also in 31, 32, 33)
  • Fixed an issue where WebContentsViews were being improperly removed. #44670 (Also in 31, 32, 33)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [electron](https://github.com/electron/electron) from 33.2.1 to 34.0.0.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v33.2.1...v34.0.0)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 20, 2025
@dependabot dependabot bot requested a review from l-alexandrov January 20, 2025 21:26
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 27, 2025

Superseded by #64.

@dependabot dependabot bot closed this Jan 27, 2025
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/electron-34.0.0 branch January 27, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants