Skip to content

assets/linux/updateBiglyBT: bashify the script #3536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fkobi wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

assets/linux/updateBiglyBT: bashify the script #3536

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
889d01c
remove newline at the end of file
fkobi Apr 17, 2025
b8b6ce4
use subshell instead of legacy ticks
fkobi Apr 17, 2025
297611f
adjust quotes
fkobi Apr 17, 2025
8ed555c
remove excess sygils
fkobi Apr 17, 2025
e9ba215
simplify ISRERUN logic
fkobi Apr 17, 2025
42960b4
run command directly
fkobi Apr 17, 2025
5c5eef9
check EUID arithmetically
fkobi Apr 21, 2025
70dbf8a
simplify PARAMS assignment
fkobi Apr 21, 2025
be93540
modernize parameter checking
fkobi Apr 21, 2025
c7bd9e5
improve PARAMS testing
fkobi Apr 21, 2025
f6a3d41
add quotes to echo
fkobi Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 22 additions & 30 deletions assets/linux/updateBiglyBT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,36 +10,29 @@ exists () {
type "$1" >/dev/null 2>/dev/null
}

if [ "$1" = "rerun" ]; then
ISRERUN=1
else
ISRERUN=0
fi
declare PARAMS=( "${@:3}" )
[[ "$1" = "rerun" ]] && declare -ri ISRERUN=1


if [ $ISRERUN -eq 1 ]; then
PARAMS=( "${@:3}" )
else
SCRIPT=`realpath $0`
SCRIPTPATH=`dirname $SCRIPT`
if [[ ! $ISRERUN ]]; then
SCRIPT=$(realpath "$0")
SCRIPTPATH=$(dirname "$SCRIPT")

if [ "$1" = "" ]; then
if [[ ! "$1" ]]; then
# No params were passed in, make ones up
PARAMS=( "com.biglybt.update.Updater" "updateonly" "${SCRIPTPATH}" "${HOME}/.biglybt" )
else
PARAMS=( "${@}" )
fi

for i in "${!PARAMS[@]}"; do
if [ "${PARAMS[$i]}" = "updateonly" ] || [ "${PARAMS[$i]}" = "restart" ]; then
PARAM_IDX_APPPATH=$(( $i + 1 ))
PARAM_IDX_APPPATH=$(( i + 1 ))
break
fi
done

if [ ! -w "${PARAMS[${PARAM_IDX_APPPATH}]}" ]; then
# Can't write to appdir, going to need super user

if [ "$EUID" -ne 0 ]; then
if (( EUID != 0 )); then
if exists "pkexec"; then
CMD="pkexec"
elif exists "gksudo"; then
Expand All @@ -50,15 +43,14 @@ else
CMD="sudo"
else
echo "Can't get write access to ${PARAMS[${PARAM_IDX_APPPATH}]}"
echo "Please run ${SCRIPT} with higher access level"
echo "Please run $SCRIPT with higher access level"
exit 1
fi

echo Running as root..
$CMD $SCRIPT "rerun" "${USER}" ${PARAMS[@]}
if [ $? -ne 0 ]; then
echo "Could not run with ${CMD}. Trying one more time with sudo"
sudo $SCRIPT "rerun" "${USER}" ${PARAMS[@]}
echo "Running as root..."
if ! $CMD "$SCRIPT" "rerun" "$USER" "${PARAMS[@]}"; then
echo "Could not run with $CMD. Trying one more time with sudo"
sudo "$SCRIPT" "rerun" "$USER" "${PARAMS[@]}"
fi
exit
fi
Expand All @@ -68,18 +60,18 @@ else
fi

for i in "${!PARAMS[@]}"; do
if [ "${PARAMS[$i]}" = "updateonly" ] || [ "${PARAMS[$i]}" = "restart" ]; then
PARAM_IDX_USERPATH=$(( $i + 2 ))
if [[ "${PARAMS[$i]}" = "updateonly" || "${PARAMS[$i]}" = "restart" ]]; then
PARAM_IDX_USERPATH=$(( i + 2 ))
break
fi
done

echo Running Updater..
java -cp "${PARAMS[${PARAM_IDX_USERPATH}]}/plugins/azupdater/Updater.jar" ${PARAMS[@]}
echo "Running Updater..."
java -cp "${PARAMS[${PARAM_IDX_USERPATH}]}/plugins/azupdater/Updater.jar" "${PARAMS[@]}"

if [ $ISRERUN -eq 1 ]; then
echo Ensuring $2 still owns ${PARAMS[${PARAM_IDX_USERPATH}]}
chown -R $2:$2 ${PARAMS[${PARAM_IDX_USERPATH}]}
if [[ $ISRERUN ]]; then
echo "Ensuring $2 still owns ${PARAMS[${PARAM_IDX_USERPATH}]}"
chown -R "$2":"$2" "${PARAMS[${PARAM_IDX_USERPATH}]}"
fi

echo Done
echo Done