Configs changes #87
Open
Configs changes #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiplier for turbine fuel
RogueLogix
requested changes
Jan 20, 2025
Member
RogueLogix
left a comment
RogueLogix
left a comment
There was a problem hiding this comment.
Given that this can be condensed into about 3 lines, I'll probably just add this myself for all branches, but i reviewed the PR anyway.
| liquidTransitions.clear(); | ||
| gasTransitions.clear(); | ||
|
|
||
| File configDir = new File(FMLPaths.GAMEDIR.get() + "/config/biggerreactors/transitions"); |
Member
There was a problem hiding this comment.
this is already set to use datapacks, and there are mods that inject dynamic datapacks
| public double turbineMultiplier; | ||
|
|
||
| @DataLoader.Range("(0,)") | ||
| public double turbineEnergyMultiplier; |
Member
There was a problem hiding this comment.
This is the wrong place to add this, it should be in the main config file, not for each transition.
|
|
||
| public class ModernTurbineSimulation implements ITurbineSimulation { | ||
|
|
Member
|
Related #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to load transitions from config; added the energy multiplier for turbine fuel. This will give more opportunities to modpack developers