feat(core): support dynamic click-through on bars based on configured modifier keys #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This code would run continually even when not in a battleground, it would need to be changed. |
Author
Thank you ! I’ve made the change, I’ll test it a bit more thoroughly to make sure it’s the right modification and didn't break anything, and then I’ll push it afterwards ! |
…nas and test mode - Add UpdateBarMouseState function to manage bar interactivity - Register MODIFIER_STATE_CHANGED only in PvP zones - Implement polling timer for test mode outside PvP zones - Apply consistent implementation across all Core files (Retail, BCC, Vanilla, Wrath) - Clean up timers and events properly in StopAllBars
Author
|
I've just pushed new changes to address two issues:
Please note that I don't have a way to test these changes on BCC Vanilla and Wrath versions. If needed, I can remove the modifications for these versions and keep only the retail changes. Let me know what you prefer, and I'll adjust accordingly ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the “click-through bars” functionality requested in Issue #130.
This pull request enhances the bar-click behaviour so that progress bars will only intercept mouse clicks when the user is holding a
modifier key that is actually configured for click-handling. In all other cases the click “passes through” to whatever UI lies beneath the bar.