Skip to content

Let you choose the Culture used for TypeConversion in the processor #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonathanantoine wants to merge 1 commit into from
Closed

Let you choose the Culture used for TypeConversion in the processor #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sieve/Models/SieveOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,7 @@ public class SieveOptions
public int MaxPageSize { get; set; } = 0;

public bool ThrowExceptions { get; set; } = false;

public string CultureNameOfTypeConversion { get; set; } = "en";
}
}
}
5 changes: 4 additions & 1 deletion Sieve/Services/SieveProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using System.ComponentModel;
using System.Globalization;
using System.Linq;
using System.Linq.Expressions;
using System.Reflection;
Expand Down Expand Up @@ -169,6 +170,8 @@ private IQueryable<TEntity> ApplyFiltering<TEntity>(
return result;
}

var cultureInfoToUseForTypeConversion = new CultureInfo(_options.Value.CultureNameOfTypeConversion ?? "en");

Expression outerExpression = null;
var parameterExpression = Expression.Parameter(typeof(TEntity), "e");
foreach (var filterTerm in model.GetFiltersParsed())
Expand All @@ -193,7 +196,7 @@ private IQueryable<TEntity> ApplyFiltering<TEntity>(
{

dynamic constantVal = converter.CanConvertFrom(typeof(string))
? converter.ConvertFrom(filterTermValue)
? converter.ConvertFrom(null, cultureInfoToUseForTypeConversion, filterTermValue)
: Convert.ChangeType(filterTermValue, property.PropertyType);

Expression filterValue = GetClosureOverConstant(constantVal, property.PropertyType);
Expand Down