Skip to content

Conversation

@sezeme
Copy link
Contributor

@sezeme sezeme commented Aug 3, 2025

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @sezeme, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature that establishes an automated workflow to integrate GitHub Pull Requests with Notion. It sets up a Node.js project with a TypeScript script that, when triggered by a PR event, extracts relevant information from the PR and uses the Notion API to update a corresponding entry in a Notion database. This aims to streamline the tracking and management of development tasks by linking them directly to GitHub PR activity.

Highlights

  • Automated Notion Integration: Introduced a new TypeScript script (scripts/sync-notion.ts) designed to run as a GitHub Action, enabling automatic synchronization of GitHub Pull Request information with Notion database entries.
  • PR-to-Notion Sync Logic: The core script extracts a document ID from the pull request's branch name (e.g., FEAT-123), queries a specified Notion database for a matching page, and then updates that page's 'GitHub Pull Requests' property with the PR's URL and its 'Status' property (e.g., '진행 중' for open, '완료' for merged) based on the PR's current state.
  • Project Setup and Dependencies: Initialized a Node.js project with package.json, pnpm-lock.yaml, and tsconfig.json, setting up necessary dependencies like @actions/core, @actions/github, and @notionhq/client for interacting with GitHub Actions and the Notion API, along with tsx for running TypeScript directly.
  • Updated Documentation: The README.md has been updated to include detailed setup instructions for both Notion (specifying the requirement for an 'ID' primary key) and GitHub secrets (explaining how to obtain and set the NOTION_DATABASE_ID).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a GitHub workflow to synchronize pull request status with a Notion database. Key areas for improvement include validating environment variables, using stable dependency versions, improving documentation, and enhancing type safety.

![기본키](assets/id.png)

github secret 설정
- 노션 데이터베이스 아이디를 레포지토리 시크릿 키로 저장해야 합니다. 데이터베이스 아이디는 노션 링크의 숫자 부분입니다.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The setup instructions should include setting NOTION_TOKEN as a repository secret, as the script requires it for Notion API authentication.

import * as core from "@actions/core";
import * as github from "@actions/github";

const notion = new Client({ auth: process.env.NOTION_TOKEN });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Validate the presence of NOTION_TOKEN before initializing the notion client to prevent potential runtime errors if the environment variable is not set.

if (!process.env.NOTION_TOKEN) {
  throw new Error("NOTION_TOKEN is not set");
}
const notion = new Client({ auth: process.env.NOTION_TOKEN });


async function run() {
try {
const dbId = process.env.NOTION_DATABASE_ID!;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Instead of using the non-null assertion operator (!), perform an explicit check for NOTION_DATABASE_ID to provide a more descriptive error message if it's not set.

const dbId = process.env.NOTION_DATABASE_ID;
if (!dbId) {
  throw new Error("NOTION_DATABASE_ID is not set");
}

Comment on lines +1 to +2
# Node.js
node_modules/ No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding the dist directory to .gitignore to prevent committing compiled build artifacts. This is a common practice to keep the repository clean.

# Node.js
node_modules/

# Build output
dist/

## 설정
notion 설정
- 식별할 수 있는 기본키 이름이 ID여야 합니다.
![기본키](assets/id.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The image assets/id.png is referenced but not included in the pull request. Ensure the image is added to the repository to avoid a broken link in the README.

"dependencies": {
"@actions/core": "^1.10.0",
"@actions/github": "^5.0.0",
"@notionhq/client": "^4.0.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The @notionhq/client dependency is set to ^4.0.1, which may be an unstable version. Consider using the latest stable version to avoid potential issues.

    "@notionhq/client": "latest",

const propStatus = process.env.NOTION_PROP_STATUS || "상태";
const propPR = process.env.NOTION_PROP_PR || "GitHub Pull Requests";

const { pull_request: pr } = github.context.payload as any;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of using as any, rely on type inference by directly accessing the pull_request property from github.context.payload.

const pr = github.context.payload.pull_request;

Comment on lines 44 to 57
const update: any = {
properties: {
[propPR]: {
url: prUrl,
},
},
};
if (prState) {
update.properties[propStatus] = {
select: { name: prState },
};
}

await notion.pages.update({ page_id: pageId, ...update });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve type safety, define a specific type for the update object's properties instead of using any.

interface UpdateProps {
  [key: string]: { url?: string; select?: { name: string } };
}

const properties: UpdateProps = {
  [propPR]: {
    url: prUrl,
  },
};

if (prState) {
  properties[propStatus] = {
    select: { name: prState },
  };
}

await notion.pages.update({ page_id: pageId, properties });

@sezeme sezeme merged commit 410dd75 into main Aug 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants