feat: add failure metrics to kinesis outbox event processing #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r failed kinesis events with error code metadata
smudge
reviewed
Nov 25, 2025
Comment on lines
17
to
20
| emit_metric('journaled.worker.batch_process', value: total_events, worker_id:) | ||
| emit_metric('journaled.worker.batch_sent', value: stats[:succeeded], worker_id:) | ||
| emit_metric('journaled.worker.batch_failed_permanently', value: stats[:failed_permanently], worker_id:) | ||
| emit_metric('journaled.worker.batch_failed_transiently', value: stats[:failed_transiently], worker_id:) |
Member
There was a problem hiding this comment.
Suggested change
| emit_metric('journaled.worker.batch_process', value: total_events, worker_id:) | |
| emit_metric('journaled.worker.batch_sent', value: stats[:succeeded], worker_id:) | |
| emit_metric('journaled.worker.batch_failed_permanently', value: stats[:failed_permanently], worker_id:) | |
| emit_metric('journaled.worker.batch_failed_transiently', value: stats[:failed_transiently], worker_id:) | |
| emit_metric('journaled.worker.batch.processed', value: total_events, worker_id:) | |
| emit_metric('journaled.worker.batch.sent', value: stats[:succeeded], worker_id:) | |
| emit_metric('journaled.worker.batch.failed_permanently', value: stats[:failed_permanently], worker_id:) | |
| emit_metric('journaled.worker.batch.failed_transiently', value: stats[:failed_transiently], worker_id:) |
🤷 nothing says we can't have more than 3 . in a stat name -- but mainly i renamed process to processed.
Member
There was a problem hiding this comment.
Though I'm wondering if we need batch_ at all. We're emitting stats in batches, but the stats themselves are counts of individual events:
Suggested change
| emit_metric('journaled.worker.batch_process', value: total_events, worker_id:) | |
| emit_metric('journaled.worker.batch_sent', value: stats[:succeeded], worker_id:) | |
| emit_metric('journaled.worker.batch_failed_permanently', value: stats[:failed_permanently], worker_id:) | |
| emit_metric('journaled.worker.batch_failed_transiently', value: stats[:failed_transiently], worker_id:) | |
| emit_metric('journaled.event.processed', value: total_events, worker_id:) | |
| emit_metric('journaled.event.sent', value: stats[:succeeded], worker_id:) | |
| emit_metric('journaled.event.failed_permanently', value: stats[:failed_permanently], worker_id:) | |
| emit_metric('journaled.event.failed_transiently', value: stats[:failed_transiently], worker_id:) |
Member
There was a problem hiding this comment.
Also thoughts on event.failed_permanently and event.failed_transiently becoming event.failed and event.errored? (Aligning with DJ terminology)
Contributor
Author
There was a problem hiding this comment.
Yeah all sounds good! will update
smudge
reviewed
Nov 25, 2025
| metrics = calculate_queue_metrics | ||
| emit_metric('journaled.worker.queue_total_count', value: metrics[:total_count], worker_id:) | ||
| emit_metric('journaled.worker.queue_workable_count', value: metrics[:workable_count], worker_id:) | ||
| emit_metric('journaled.worker.queue_erroring_count', value: metrics[:erroring_count], worker_id:) |
Member
There was a problem hiding this comment.
Suggested change
| emit_metric('journaled.worker.queue_erroring_count', value: metrics[:erroring_count], worker_id:) | |
| emit_metric('journaled.worker.queue_failed_count', value: metrics[:erroring_count], worker_id:) |
Should it be "failed count"? If it's a batch query it can really only count the number of hard-failed rows, not the number of transiently-erroring rows, right?
smudge
requested changes
Nov 25, 2025
Member
smudge
left a comment
smudge
left a comment
There was a problem hiding this comment.
TAFN - two points on naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds more visibility into both batch and individual kinesis errors by emitting metrics with event information and error codes. This will allow us to track rate limiting errors more closely, and have insight into other errors that occur.
/no-platform