feat: Add wrapper parameter to goldenTest function#172
Open
w3ggy wants to merge 2 commits intoBetterment:mainfrom
Open
feat: Add wrapper parameter to goldenTest function#172w3ggy wants to merge 2 commits intoBetterment:mainfrom
goldenTest function#172w3ggy wants to merge 2 commits intoBetterment:mainfrom
Conversation
Contributor
Author
|
I added an example but I cannot update goldens inside example using workflow https://github.com/w3ggy/alchemist/actions/runs/20094102542 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Possible fix of the #86. The cause of the issue is that we need to wrap up the code of the test body which is launched inside another zone in custom zone. There is no strict way in the current method signature to pass the wrapper.
The proposed solution from the thread
is not good enough because we have to wrap up the next pumps as well. It is more just like a proposal but this one is working on my end. I am not sure what kind of tests I can (should) add for this tweak.
Type of Change