Draft for searchMapPlaceController + bugfix#16
Draft
roisnir wants to merge 2 commits intoBernardi23:masterfrom
Draft
Draft for searchMapPlaceController + bugfix#16roisnir wants to merge 2 commits intoBernardi23:masterfrom
roisnir wants to merge 2 commits intoBernardi23:masterfrom
Conversation
Owner
|
I'll take a look. But I'm doing a pretty important commit tonight that fixes a lot of stuff, therefore this will probably have some conflicts. Even though my commit doesn't solve #14, it makes the UX a lot better, since it allows the user to close the Box by hitting the "Submit" button on the keyboard. |
Owner
|
I pushed the new update yesterday. Check it out and see if you can add this feature on it. |
|
@Bernardi23 com este fix e55e9d6 é possível retornar o Place selecionado para outra tela. É possível priorizá-lo ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About issue #14 this is the quick solution that I used in my project. What do you think?
If this direction is good we can improve it, write it better or even check how other controllers are implemented.
The second commit fixes an error the appears after the widget is disposed and the custom listener keeps running.
@Bernardi23 what do you think?