Skip to content

Draft for searchMapPlaceController + bugfix#16

Draft
roisnir wants to merge 2 commits intoBernardi23:masterfrom
roisnir:master
Draft

Draft for searchMapPlaceController + bugfix#16
roisnir wants to merge 2 commits intoBernardi23:masterfrom
roisnir:master

Conversation

@roisnir
Copy link
Copy Markdown

@roisnir roisnir commented Apr 10, 2020

About issue #14 this is the quick solution that I used in my project. What do you think?
If this direction is good we can improve it, write it better or even check how other controllers are implemented.

The second commit fixes an error the appears after the widget is disposed and the custom listener keeps running.

@Bernardi23 what do you think?

@Bernardi23
Copy link
Copy Markdown
Owner

I'll take a look. But I'm doing a pretty important commit tonight that fixes a lot of stuff, therefore this will probably have some conflicts.

Even though my commit doesn't solve #14, it makes the UX a lot better, since it allows the user to close the Box by hitting the "Submit" button on the keyboard.

@Bernardi23
Copy link
Copy Markdown
Owner

I pushed the new update yesterday. Check it out and see if you can add this feature on it.

@rubensdemelo
Copy link
Copy Markdown

@Bernardi23 com este fix e55e9d6 é possível retornar o Place selecionado para outra tela. É possível priorizá-lo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants