Move input validation from init to updateView#108
Open
Philschke wants to merge 2 commits intoBenediktBergmann:masterfrom
Open
Move input validation from init to updateView#108Philschke wants to merge 2 commits intoBenediktBergmann:masterfrom
Philschke wants to merge 2 commits intoBenediktBergmann:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Overview
In addition to my recently raised issue #75,
I investigated the root cause and resolved it. This PR improves the control lifecycle by ensuring that input validation is performed in
updateViewinstead ofinit.❓ Why
According to Microsoft’s PCF guidelines:
Running validation in
initcould therefore result in:🔧 Changes Made
checkInputcall frominitupdateView, where parameters are guaranteed to be populatedinitfocused only on DOM setup and event handler registration🎯 Benefits