-
Notifications
You must be signed in to change notification settings - Fork 1
Add batch_generate method to ModelAdapter for concurrent prompt proce… #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yanurag-dev
wants to merge
2
commits into
Benchwise:develop
Choose a base branch
from
yanurag-dev:feat/Add-batch-processing
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect index assignment for uncaught exceptions.
Line 136 uses
len(processed_results)as the index for uncaught exceptions, which assumes exceptions are processed in order and no previous exceptions occurred. However, if an exception occurs at index 2 and this is the first item processed, it would be assigned index 0 instead of 2, breaking order preservation.Since
process_single_promptalready returns(index, result)tuples and catches exceptions internally, exceptions reaching this point indicate a serious bug (e.g., in the exception handling itself). Consider logging these as critical errors instead of trying to recover:# Handle any exceptions that weren't caught processed_results = [] for item in results_with_indices: if isinstance(item, Exception): - processed_results.append((len(processed_results), f"Error: {str(item)}")) + logger.critical(f"Unexpected exception escaped process_single_prompt: {item}") + # This should never happen, indicates a bug in process_single_prompt + raise item else: processed_results.append(item)Alternatively, if you want to be defensive, you need to track which index failed. However, since
asyncio.gatherdoesn't preserve position information when returning exceptions, you'd need to useasyncio.create_taskwith tracking orasyncio.as_completed.🧰 Tools
🪛 Ruff (0.14.8)
136-136: Use explicit conversion flag
Replace with conversion flag
(RUF010)
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodeRabbit If exception occurred at index 2 so there would be two item already in processed_results and length will be 2, so exception will be added on index 2 not on 0.
I'm quoting you on this
Line 136 uses len(processed_results) as the index for uncaught exceptions, which assumes exceptions are processed in order and no previous exceptions occurred. However, if an exception occurs at index 2 and this is the first item processed, it would be assigned index 0 instead of 2, breaking order preservation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yanurag-dev You're absolutely right, and I apologize for the confusion in my analysis.
Since
asyncio.gather()preserves the order of results and we iterate throughresults_with_indicessequentially,len(processed_results)at each iteration does indeed equal the current index. So if an exception occurs at position 2, by the time we reach it in the iteration,processed_resultswould already contain 2 items (from indices 0 and 1), makinglen(processed_results) == 2, which is the correct index.The code is actually working as intended. This exception handling block serves as defensive code for truly unexpected errors (like a bug in
process_single_promptitself or the semaphore failing), sinceprocess_single_promptis designed to catch all exceptions internally and always return a(index, result_or_error)tuple.Thank you for the correction!