Fix some compile issues and add a feature #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is untested
Otherwise httpfs could loop accessing an URL redirecting to non-reachable server.
This is reported in Debian bug #716022 When not enough arguments are provided by the user NULL argument is dereferenced in option parser. Require one more argument to be non-null since at least two non-option arguments are required anyway. This is a cosmetical change - instead of segfault usage message is printed. The referenced argument is guaranteed to be null and cause crash without the extra check.
…> date: Tue Jul 19 17:06:20 2016 +0200 summary: Fix gnutls build-dependency.
This includes renogotiation which was broken. Compile-tested.
The handler could loop on 0 return value. Don't call it on 0 and reject 0 in the handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. A couple of things:
Feel free to improve it more
Thanx