Skip to content

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Apr 27, 2025

User description

5.40.0 no changelog listed


PR Type

enhancement, other


Description

  • Added configuration for Perl 5.40.0 release.

  • Updated build.properties with new release date.

  • Registered Perl 5.40.0 in releases.properties.


Changes walkthrough 📝

Relevant files
Enhancement
bearsampp.conf
Add bearsampp.conf for Perl 5.40.0 configuration                 

bin/perl5.40.0/bearsampp.conf

  • Added new configuration file for Perl 5.40.0.
  • Set Perl version and executable path.
  • Included bundle release placeholder.
  • +4/-0     
    build.properties
    Update bundle release date in build.properties                     

    build.properties

    • Updated bundle.release date to 2025.4.26.
    +1/-1     
    releases.properties
    Register Perl 5.40.0 in releases.properties                           

    releases.properties

  • Registered new entry for Perl 5.40.0 release.
  • Linked to new release package URL.
  • +1/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @N6REJ N6REJ added the enhancement ✨ Improve program label Apr 27, 2025
    @qodo-code-review
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    @qodo-code-review
    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Fix inconsistent URL format

    The version format in the URL path is inconsistent with previous entries. The
    URL should include the full version number (5.40.0) in the download path instead
    of just the date.

    releases.properties [3]

    -5.40.0 = https://github.com/Bearsampp/module-perl/releases/download/2025.4.26/bearsampp-perl-5.40.0-2025.4.26.7z
    +5.40.0 = https://github.com/Bearsampp/module-perl/releases/download/5.40.0/bearsampp-perl-5.40.0-2025.4.26.7z
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    __

    Why: The suggestion correctly identifies an inconsistency in the URL format. Previous entries use the version number in the download path (5.32.1.1 and 5.38.2.2), while the new entry uses only the date (2025.4.26). Maintaining consistent URL patterns is important for reliability and predictability.

    Medium
    • More

    @jwaisner jwaisner merged commit df50e98 into main Apr 27, 2025
    1 check passed
    @jwaisner jwaisner deleted the 5.40.0 branch April 27, 2025 19:47
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    enhancement ✨ Improve program

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants