Clarify external API pattern does not require instance() wrapper #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review feedback suggested using
instance()from@/apifor Discogs/Wikidata/MusicBrainz API calls. However,instance()is Spotify-specific with OAuth token refresh and Spotify base URL hardcoded.Current Implementation (Correct)
ky.create()instances with appropriate auth:Authorization: Discogs token=${DISCOGS_TOKEN}instance()for "Spotify API calls" specificallyNo Changes Required
The existing pattern correctly isolates external API concerns. Using
instance()would leak Spotify OAuth headers to third-party services.Awaiting confirmation this pattern is acceptable before closing.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.