Simplify FS.CreateDirectory return value #453
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change FS.CreateDirectory to return nil on success instead of a pair. On error, returns the error message string directly. Closes BeamMP#187
Collaborator
|
This is a nice change, however it will most likely break a lot of widely used server plugins. I'm not sure if it's worth the trade off. |
Contributor
Author
|
I see what you mean, but at some point we need to improve things. If it could cause problems, we should warn people for the future, but implement it anyway to make things cleaner. |
Collaborator
|
I suspect warning people will not be sufficient in this case. Most people don't update their server plugins (often) so this change would be harming a lot of casual players for a slight correction in the lua api design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change FS.CreateDirectory to return nil on success instead of a pair. On error, returns the error message string directly.
Closes #187