Skip to content

Patch 1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k-rafalyuk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Patch 1 #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32c286
Update ClientDao.java
k-rafalyuk Nov 11, 2016
bdaecd2
Update ClientDao.java
k-rafalyuk Nov 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/Basov/NCdevcourses/dao/ClientDao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
@Component
public class ClientDao implements ClientDaoInterface <ClientEntity, Integer>{

// При таком подходе эти переменные шарятся на все потоки и если два потока одновременно зайдут в объект ClientDao,
// и работать будет совсем не так, как задумывалось, а вернее, вообще работать не будет. Менеджить сессии и транзакции надо либо
// в самих методах, которые априори потокобезопасны, либо поручить это самому hibernate
// Плюс транзакции очень желательно вынести на сервис слой
private Session currentSession;
private Transaction currentTransaction;

Expand Down