-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update fasd to use installed version instead of embedded #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This brings the fasd up to November 5, 2015. Commit imported: clvv/fasd@d41c4b0
|
@nwinkler would appreciate a second set of eyes on this before I merge. I was trying to fix fasd swallowing Couple of things to check:
|
|
FWIW, there was something up with my shell that caused this to succeed falsely. I'm in the process of removing this plugin entirely in favor of installing it and using a custom |
There are multiple ways to install fasd, but the initialization still needs to happen. Currently, fasd is broken in bash in that it doesn't maintain the exit code properly. This custom init removes the call to `fasd --init bash-hook` and replaces it with the version that would be generated once fasd PR Bash-it#72 is merged. See: clvv/fasd#72
|
Note, this PR includes a work around for clvv/fasd#72. Once that is merged we can simply replace the entire |
|
Ok, with the latest commits I'm back to understanding what's going on. Some ghost shell variables or something was causing it to initialize properly earlier. Going to go ahead and merge, but would still be curious for any feedback y'all have. |
|
Thanks @tswicegood for the fix, I stopped using fasd because this. |
|
Good stuff - I had stopped using fasd because of this issue as well. Time to enable it again! Thanks for working on this! |
This removes the embedded version of fasd in favor of installed versions. I've included an error message when enabled and unable to find the
fasdexecutable.