command duration fix by BarbUk · Pull Request #2366 · Bash-it/bash-it

BarbUk · 2026-02-03T16:03:28Z

Fix command duration lib to display the actual time a command took

Description

Delete preexec vendor
Squashed 'vendor/github.com/rcaloras/bash-preexec/' content from commit b73ed5f7
Update precommit
Rework command duration plugin to handle locale with . or , and remove subshell
Sh format

Motivation and Context

Command duration lib was updated in #2271 to fix an issue with the locale defined in the command duration lib.
The locale was forced to ensure that the decimal point of EPOCHREALTIME is the period.

The fix introduce a subshell, the preexec vendor has an issue with subshells:
https://github.com/rcaloras/bash-preexec/?tab=readme-ov-file#subshells

This PR update preexec to the last stable tag (0.6.0), update the command duration lib to remove the subshell and handle locale with period or comma.

How Has This Been Tested?

Before:

~ ❯ sleep 1

~ 🕒 3.6s ❯ sleep 2

~ 🕒 3.8s ❯

After:

 ~ ❯ sleep 1

 ~ 🕐 1.0s ❯ sleep 2

 ~ 🕑 2.1s ❯

Screenshots (if appropriate):

Before: left, after: right

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
If my change requires a change to the documentation, I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
I have added tests to cover my changes, and all the new and existing tests pass.

…it b73ed5f7 git-subtree-dir: vendor/github.com/rcaloras/bash-preexec git-subtree-split: b73ed5f7f953207b958f15b1773721dded697ac3

git-vendor-name: preexec git-vendor-dir: vendor/github.com/rcaloras/bash-preexec git-vendor-repository: https://github.com/rcaloras/bash-preexec git-vendor-ref: 0.6.0

…e subshell

vendor/github.com/rcaloras/bash-preexec/test/bash-preexec.bats

vendor/github.com/rcaloras/bash-preexec/test/include-test.bats

This reverts commit 7ab0074.

lib/command_duration.bash

@akinomyoga

Technically, one can define a locale with decimal_point being an arbitrary string. For example, ps_AF seems to use U+066B as the decimal point Thanks @akinomyoga for the feedback

akinomyoga · 2026-02-03T19:45:24Z

The fix introduce a subshell, the preexec vendor has an issue with subshells:
https://github.com/rcaloras/bash-preexec/?tab=readme-ov-file#subshells

The subshell mentioned in the bash-preexec README is unrelated to the present subshell for the shell function. bash-preexec may not reliably trigger the preexec hook before the execution of a user command starting with ( cmd... ). It has an option to try to fix it, but it causes other problems.

On the other hand, the code that this PR tries to fix is not used in a form (...). It is not a code executed inside a user command either. It is rather a command executed inside the preexec hook itself. In addition, even if any subshells (not only the ones called in the form (...)) are affected, this PR still uses a subshell through $(...).

I doubt bash-prexec is related. What is your original problem?

BarbUk · 2026-02-03T19:58:26Z

What is your original problem?

The shell duration lib was not counting the duration between the start of a command to the end of that command, but from start of the prompt to the end of the next command.

So the time was always wrong.

The subshell mentioned in the bash-preexec README is unrelated to the present subshell for the shell function. bash-preexec may not reliably trigger the preexec hook before the execution of a user command starting with ( cmd... ). It has an option to try to fix it, but it causes other problems.

I maybe made a mental shortcut about this.

But updating the preexec vendor and removing the sub-shell to get EPOCHREALTIME fixed the issue.

BarbUk · 2026-02-03T20:01:38Z

vendor/github.com/rcaloras/bash-preexec/test/include-test.bats

akinomyoga · 2026-02-03T20:11:17Z

But updating the preexec vendor and removing the sub-shell to get EPOCHREALTIME fixed the issue.

So you applied two changes to fix the problem. Have you checked that both changes are actually needed to fix the problem? In particular, does changing { ... } of the function body of _command_duration_current_time() back to ( ... ) re-introduce the original problem?

BarbUk · 2026-02-03T20:36:59Z

So you applied two changes to fix the problem. Have you checked that both changes are actually needed to fix the problem? In particular, does changing { ... } of the function body of _command_duration_current_time() back to ( ... ) re-introduce the original problem?

Just made a test case.
This is definitely the vendors update that fix the issue.

The precedent version was 0.4.1.
Testing with the 0.5.0 release, I still have the issue.
The 0.6.0 fix the issue.

I see that you made several PR for this release (thank you).
Just testing the PR patch from the 0.5.0 version, this is your PR that fix the issue:
rcaloras/bash-preexec#141

   ~/.dotfiles/modules/bash-it on  detached:d4fa26e5  b ✓ ❯ git vendor update preexec 0.5.0
From https://github.com/rcaloras/bash-preexec
 * tag                 0.5.0      -> FETCH_HEAD
From https://github.com/rcaloras/bash-preexec
 * tag                 0.5.0      -> FETCH_HEAD
Subtree is already at commit da64ad4b7bb965d19dbeb5bb7447f1a63e3de2e3.

   ~/.dotfiles/modules/bash-it on  detached:d4fa26e5  b ✓ 🕑 2.3s ❯ cd vendor/github.com/rcaloras/bash-preexec/

   ~/.../github.com/rcaloras/bash-preexec on  detached:d4fa26e5  b ✓ ❯ patch -p1 < <(curl -s https://patch-diff.githubusercontent.com/raw/rcaloras/bash-preexec/pull/141.patch)

   ~/.../github.com/rcaloras/bash-preexec on  detached:d4fa26e5  b ✓  130 ❯ patch -p1 < <(curl -s https://patch-diff.githubusercontent.com/raw/rcaloras/bash-preexec/pull/128.patch)
patching file bash-preexec.sh
Hunk #1 succeeded at 309 (offset 2 lines).

   ~/.../github.com/rcaloras/bash-preexec on  detached:d4fa26e5 •1 ⌀1  b ✗ ❯ patch -p1 < <(curl -s https://patch-diff.githubusercontent.com/raw/rcaloras/bash-preexec/pull/127.patch)
patching file bash-preexec.sh

   ~/.../github.com/rcaloras/bash-preexec on  detached:d4fa26e5 •1 ⌀1  b ✗ 🕐 1.5s ❯ patch -p1 < <(curl -s https://patch-diff.githubusercontent.com/raw/rcaloras/bash-preexec/pull/136.patch)
patching file README.md
patching file bash-preexec.sh
Hunk #1 succeeded at 38 (offset -3 lines).
patching file test/bash-preexec.bats

   ~/.../github.com/rcaloras/bash-preexec on  detached:d4fa26e5 •3 ⌀1  b ✗ ❯ patch -p1 < <(curl -s https://patch-diff.githubusercontent.com/raw/rcaloras/bash-preexec/pull/141.patch)
patching file bash-preexec.sh
Hunk #1 succeeded at 176 (offset -7 lines).
Hunk #2 succeeded at 283 (offset -7 lines).
Hunk #3 succeeded at 321 (offset -10 lines).
Hunk #4 succeeded at 357 (offset -10 lines).
patching file test/bash-preexec.bats

My test case is working after the PR 141 patch.

akinomyoga

I was about to request separating the necessary changes and cosmetic changes (to make the intent of the changes clearer in the Git history), but I realized that this plugin was actually introduced by @BarbUk. Then, I wouldn't require explanations on the style changes, etc.

lib/command_duration.bash

plugins/available/cmd-returned-notify.plugin.bash

lib/command_duration.bash

BarbUk · 2026-02-10T15:47:43Z

Thanks @akinomyoga for the time you took for this review.
I've fixed the issues.

The command duration lib now works in microseconds directly.
I've added a COMMAND_DURATION_PRECISION to handle the microseconds truncate for the display.

It's configured at 1 by default to not change the way it was working before.

I'll try to add some bats test for the lib.

test/lib/command_duration.bats

BarbUk · 2026-02-10T20:18:28Z

I'll try to add some bats test for the lib.

Tests added.

The tests showed there was still an issue with leading 0 while doing the microseconds truncate (same issue as this review: #2366 (comment))

This was fixed in 42b8086 and 5ef3b70

lib/command_duration.bash

BarbUk · 2026-02-11T19:18:15Z

Thanks again @akinomyoga for the review. Very nice and informative.

I've fixed all points and added some bats tests to check how the code is handling the output when $EPOCHREALTIME is not available.

akinomyoga

Thank you for updating. The following is the remaining change that I suggested in the previous comment, but that might not be clear.

edit: Hmm, due to the GitHub interface, it still seems confusing. In the following three comments, I suggest the following change:

  		if ((minutes > 0)); then
 			printf "%s %s%dm %ds" "${COMMAND_DURATION_ICON:-}" "${COMMAND_DURATION_COLOR:-}" "$minutes" "$seconds"
-		elif ((COMMAND_DURATION_PRECISION > 0)); then
+		else
 			printf "%s %s%ss" "${COMMAND_DURATION_ICON:-}" "${COMMAND_DURATION_COLOR:-}" "$seconds${microseconds:+.$microseconds}"
-		else
-			printf "%s %s%ds" "${COMMAND_DURATION_ICON:-}" "${COMMAND_DURATION_COLOR:-}" "$seconds"
 		fi

lib/command_duration.bash

BarbUk · 2026-02-12T19:01:21Z

The following is the remaining change that I suggested in the previous comment, but that might not be clear.

Yes, I did not understand it that way.

I removed the unused code branch and added a new test case with precision 0 and microseconds time.

akinomyoga

Thank you! LGTM now!

BarbUk added 6 commits February 3, 2026 16:33

Delete preexec vendor

0119368

Squashed 'vendor/github.com/rcaloras/bash-preexec/' content from comm…

027b7ae

…it b73ed5f7 git-subtree-dir: vendor/github.com/rcaloras/bash-preexec git-subtree-split: b73ed5f7f953207b958f15b1773721dded697ac3

Add "preexec" from "https://github.com/rcaloras/bash-preexec@0.6.0"

b509d72

git-vendor-name: preexec git-vendor-dir: vendor/github.com/rcaloras/bash-preexec git-vendor-repository: https://github.com/rcaloras/bash-preexec git-vendor-ref: 0.6.0

Update precommit

7ab0074

Rework command duration plugin to handle locale with . or , and remov…

ee821b3

…e subshell

Sh format

f630441

github-advanced-security bot found potential problems Feb 3, 2026

View reviewed changes

BarbUk added 7 commits February 3, 2026 17:55

Revert "Update precommit"

b42c3ac

This reverts commit 7ab0074.

Fix cmd-returned-notify.plugin.bash

1857412

Fix _shell_duration_en function call, restore original variable names

83f11a8

With recent version of bash preexec set PROMPT_COMMAND as an array

64ec7e7

But leave test for old macos version of bash

4c60358

New version of preexec add a :

5ae5522

Fix preexec bats tests shellcheck errors

f689001

akinomyoga reviewed Feb 3, 2026

View reviewed changes

lib/command_duration.bash Outdated Show resolved Hide resolved

BarbUk added 2 commits February 3, 2026 20:42

, and . are not the only possibilities of decimal_point

d65288f

Technically, one can define a locale with decimal_point being an arbitrary string. For example, ps_AF seems to use U+066B as the decimal point Thanks @akinomyoga for the feedback

Ignore warning for vendors bats test files

2339683

BarbUk added 2 commits February 3, 2026 21:10

Add default for COMMAND_DURATION_START_SECONDS

3e3ddf3

Fix shellcheck SC1091 for vendor bats tests

7373708

github-advanced-security bot found potential problems Feb 3, 2026

View reviewed changes

vendor/github.com/rcaloras/bash-preexec/test/include-test.bats Fixed Show fixed Hide fixed

Ignore last shellcheck error in vendor bats tests

9e88c2a

seefood self-assigned this Feb 8, 2026

seefood requested a review from akinomyoga February 8, 2026 17:03

akinomyoga suggested changes Feb 10, 2026

View reviewed changes

lib/command_duration.bash Outdated Show resolved Hide resolved

plugins/available/cmd-returned-notify.plugin.bash Outdated Show resolved Hide resolved

lib/command_duration.bash Show resolved Hide resolved

Add more information about the reason of this change

1fb6e65

BarbUk added 4 commits February 10, 2026 16:23

Get the current time from command_duration lib function

f775bbd

Work with microseconds, truncate the output to display

53de05d

Only calculate and display microseconds if precision > 0

4d86661

Add documentation about COMMAND_DURATION_PRECISION

ee1c783

BarbUk added 4 commits February 10, 2026 19:36

Handle case with leading 0 in microseconds

42b8086

Handle case with leading 0 in microseconds

5ef3b70

No quote for integer local var

9e5f7ce

Add tests

c0f2a5d

github-advanced-security bot found potential problems Feb 10, 2026

View reviewed changes

Disable shellcheck false positive for bats tests

964e9bc

akinomyoga suggested changes Feb 10, 2026

View reviewed changes

akinomyoga reviewed Feb 10, 2026

View reviewed changes

lib/command_duration.bash Outdated Show resolved Hide resolved

lib/command_duration.bash Outdated Show resolved Hide resolved

lib/command_duration.bash Outdated Show resolved Hide resolved

lib/command_duration.bash Outdated Show resolved Hide resolved

BarbUk added 7 commits February 11, 2026 06:55

local -> locale

67cb1b2

Rephrase

3c39331

overide -> override

275c8d3

Fix phrasing

910dbed

Add tests when EPOCHREALTIME is not available

43f1bd4

Uses string instead of int

b848e5b

Reintroduce paste documentation to keep context about this change

71a8a71

akinomyoga reviewed Feb 11, 2026

View reviewed changes

lib/command_duration.bash Outdated Show resolved Hide resolved

lib/command_duration.bash Show resolved Hide resolved

lib/command_duration.bash Outdated Show resolved Hide resolved

BarbUk added 2 commits February 12, 2026 22:58

Remove unused code branch

dd80054

Add test with precision 0 and microseconds time

ed314d5

akinomyoga approved these changes Feb 12, 2026

View reviewed changes

seefood merged commit bc7e726 into Bash-it:master Feb 13, 2026
6 checks passed

Comments

Conversation

BarbUk commented Feb 3, 2026

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

akinomyoga commented Feb 3, 2026

Uh oh!

BarbUk commented Feb 3, 2026

Uh oh!

BarbUk commented Feb 3, 2026

Uh oh!

Uh oh!

akinomyoga commented Feb 3, 2026

Uh oh!

BarbUk commented Feb 3, 2026

Uh oh!

akinomyoga left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BarbUk commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BarbUk commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BarbUk commented Feb 11, 2026

Uh oh!

akinomyoga left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BarbUk commented Feb 12, 2026

Uh oh!

akinomyoga left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BarbUk commented Feb 10, 2026 •

edited

Loading

akinomyoga left a comment •

edited

Loading

akinomyoga left a comment •

edited

Loading