feat add chat file drag and drop and cmd plus v to paste #4337
+229
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces drag-and-drop and paste functionalities for files and images in the chat, which is a great enhancement for the desktop experience. The implementation correctly uses desktop_drop and pasteboard packages. My review focuses on improving the robustness of these new features by adding proper error handling for asynchronous operations. I've identified a couple of places where unhandled exceptions could lead to app instability or crashes, and I've provided suggestions to make the code more resilient, aligning with the guideline that try-catch blocks are necessary for operations with a non-negligible chance of failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-01-22.at.1.08.05.PM.mov