-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Pump version 3.0.15 #4336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pump version 3.0.15 #4336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the firmware version to 3.0.15. The change correctly updates the firmware revision string in the omi.conf file. This is a standard procedure for a new release. The change is straightforward and I found no issues with it.
| is_hardware_available = true; | ||
| LOG_INF("Wi-Fi hardware is ready"); | ||
|
|
||
| // check if Wi-Fi hardware is broken/unavailable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove dupplicated code
| CONFIG_NRF70_AP_MODE=y | ||
| CONFIG_WIFI_NM_WPA_SUPPLICANT_AP=y | ||
| CONFIG_NRF_WIFI_LOW_POWER=n | ||
| CONFIG_NRF70_QSPI_LOW_POWER=n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let wifi enter low power when it's not used
|
lgtm @TuEmb |

Release check list:
Power Consumption Profile:
Offline Mode:

Live Mode:

BLE Sync Mode:

Deepsleep Mode:
