Skip to content

fix stop reporting socket errors as crashes #4119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krushnarout wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix stop reporting socket errors as crashes #4119

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5b5b22
fix stop reporting socket errors as crashes
krushnarout Jan 7, 2026
e5b3d7f
report non-socket errors to crash reporter
krushnarout Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/lib/services/sockets/pure_socket.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,9 @@ class PureSocket implements IPureSocket {
});

_listener?.onError(err, trace);
PlatformManager.instance.crashReporter.reportCrash(err, trace);
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Completely removing crash reporting is too broad and can hide legitimate application bugs. For instance, an exception in an onMessage handler would be caught here but would no longer be reported. It's better to conditionally report crashes, filtering out expected network errors like SocketException and WebSocketChannelException.

    // Only report unexpected errors as crashes, not common network issues.
    if (err is! SocketException && err is! WebSocketChannelException) {
      PlatformManager.instance.crashReporter.reportCrash(err, trace);
    }

if (err is! SocketException && err is! WebSocketChannelException) {
PlatformManager.instance.crashReporter.reportCrash(err, trace);
}
}

@override
Expand Down