Conversation
MaGOs92
approved these changes
Oct 29, 2025
| // Messages de succès à ignorer | ||
| if ( | ||
| [ | ||
| "traité avec succès", |
Collaborator
There was a problem hiding this comment.
on peut pas se baser sur autre chose qu'un message en toutes lettres?
Collaborator
Author
There was a problem hiding this comment.
C'est le code de la BAN, je suis pas rentré en détails dans les alertes. Je suppose que si Jugurtha a fait comme ca, c'est qu'il n'avait pas trop le choix.
Après quand je regarde l'alert, il y a vraiment le status et le message, ils ont un truc beaucoup moins évolué que le validateur
| } | ||
|
|
||
| return null; | ||
| } |
Collaborator
There was a problem hiding this comment.
ça serait mieux de déplacer toute cette logique dans un fichier utils ou autre. Mais éviter de la laisser dans le composant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET
https://projets.suite.anct.gouv.fr/cards/1627723688591754325
FONCTIONNALITE