Skip to content

Conversation

@gdzqzzx
Copy link

@gdzqzzx gdzqzzx commented Jul 5, 2021

  1. Add NVivo12 selection for Normalization
  2. Fixed bugs in Tagging and Annotations
  3. Add --drop flag for keeping NVivo DB

gdzqzzx added 3 commits July 5, 2021 19:47
Adjust NVivo 12 (using MSSQL14)
Tagging: remove StartZ.is_(None) condition.
Annotation: add missing parentheses in StartText and LengthText selection.
Add --drop flag for dropping/keeping NVivo DB
@gdzqzzx gdzqzzx closed this Jul 5, 2021
@gdzqzzx gdzqzzx reopened this Jul 5, 2021
@jschultz
Copy link
Collaborator

jschultz commented Jul 8, 2021

Thanks @gdzqzzx I'm happy to see your work laid out like this. The usual practice is to make separate pull requests for each change, so that I can accept them separately. But don't worry about it - the changes are small enough that I can easily work my way through them.
Some points:
I worked out that that the ThumbnailLocation and WaveformLocation fields were from the Mac version of NVivo 12, so I'll adapt your changes accordingly.
I'm not convinced that the --drop flag is a useful addition. The idea is that the NormaliseNVP and DenormaliseNVP scripts do as they say, nothing more or less. To do a finer level of detail I prefer that the user use the mssqlAttach script followed by Normalise then (if they want) mssqlDrop.
Also, wasn't there another bug you found where StartY was 0-based while StartX was 1-based (or was it the other way around)?

Convert StartY from 0-based to 1-based in Tagging.Fragment.
@gdzqzzx
Copy link
Author

gdzqzzx commented Jul 8, 2021

Thanks for your reminding @jschultz , I have pushed a new commit on StartY fixing, but I failed to find a way to make a new pull request for this new commit, sorry about that.

For the StartY bug, I''m not pretty sure whether it IS a bug: in my version of nvp file, NVivo StartX is 0-based, but NVivo StartY is already 1-based (and I can use StartY directly to merge Tagging with RowId in original datasets). So what I did is just remove the add-1 action on StartY.

As for the --drop flag, I agree with you and I added it just for my project‘s convenience. Maybe I shall try your method on it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants