Remove static nonsense

[henke37]

Make the constructor a proper constructor, remove the getters, put the logic of the getters in the constructor.
Then remove the static keyword from all methods and properties.

[henke37]

You can probably merge the Assembler class into the EasyBase class.

[Barliesque]

As soon as I get a chance I'll have a look at your amendments and probably merge it in.

While you could merge the Assembler class into the EasyBase class, I'm inclined to leave it as written by Adobe, so that updated versions can be easily dropped in without having to do a bunch of cutting and pasting of code.

Thanks both of you for your feedback!

[henke37]

I meant the other Assembler class, the one actually named as such and being a part of the project.

I think the fact that I added a property named "realAssembler" is a clue that something is wrong with the design. The Assembler class just has a couple of very thin wrapper methods. It should be merged into the EasyBase class.

[Barliesque]

Ahh. That makes sense. Pardon the confusion -- I haven't had a chance yet
to actually look at the code.

On Mon, Mar 23, 2015 at 3:48 PM, henke37 notifications@github.com wrote:

I meant the other Assembler class, the one actually named as such and
being a part of the project.

I think the fact that I added a property named "realAssembler" is a clue
that something is wrong with the design. The Assembler class just has a
couple of very thin wrapper methods. It should be merged into the EasyBase
class.

—
Reply to this email directly or view it on GitHub
#4 (comment).

[b005t3r]

@henke37, I'll be merging this pull request soon (can do it right now, as it breaks a couple of things I'm using right now), so if you have any comments/pointers or would like to inform me about anything - this is the right time to do it :)

[henke37]

I have nothing specific to say. But I can give you a heads up that I wrote it here on the website and never test compiled it. I vaguely recall there being "something" I neglected to fix after my surgery too. More fun for you then!

[b005t3r]

What? :) You mean you never even compiled it? :)