Skip to content

Optimize recursive dns bruteforce method#38

Open
Bandit-HaxUnit wants to merge 3 commits intomasterfrom
cursor/optimize-recursive-dns-bruteforce-method-836e
Open

Optimize recursive dns bruteforce method#38
Bandit-HaxUnit wants to merge 3 commits intomasterfrom
cursor/optimize-recursive-dns-bruteforce-method-836e

Conversation

@Bandit-HaxUnit
Copy link
Copy Markdown
Owner

Refactor _recursive_dnsx_bruteforce method to enhance reliability, performance, and resource management.

The previous implementation suffered from race conditions due to shared file I/O, inefficient memory usage from duplicate data, and lacked robust error handling and progress tracking. This refactor addresses these issues by introducing thread-safe operations, proper deduplication, adaptive threading, and comprehensive resource management.

cursoragent and others added 2 commits July 17, 2025 16:55
…mprovements

Co-authored-by: ek <ek@drimble.com>
cursor[bot]

This comment was marked as outdated.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing Wildcard Detection in DNSX Command

The dnsx command within the _recursive_dnsx_bruteforce function is missing the -wd {subdomain_target} wildcard detection parameter. While the original implementation included both -wd {subdomain} and -wd {self.site}, the updated command only retains -wd {self.site}. This omission removes wildcard detection for the specific subdomain being tested, which can lead to false positives from wildcard DNS responses.

main.py#L644-L652

haxunit/main.py

Lines 644 to 652 in 75b9aa1

# Build command
cmd = (
f"dnsx -silent -d {subdomain_target} "
f"-w {wordlist} "
f"-wd {self.site} "
f"-o {output_file} "
f"-r 8.8.8.8,1.1.1.1 " # Multiple resolvers for reliability
f"-retry 2 -timeout 5"
)

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Copy link
Copy Markdown
Contributor

@x-stp x-stp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants