Optimize recursive dns bruteforce method#38
Open
Bandit-HaxUnit wants to merge 3 commits intomasterfrom
Open
Conversation
…ability Co-authored-by: ek <ek@drimble.com>
…mprovements Co-authored-by: ek <ek@drimble.com>
There was a problem hiding this comment.
Bug: Missing Wildcard Detection in DNSX Command
The dnsx command within the _recursive_dnsx_bruteforce function is missing the -wd {subdomain_target} wildcard detection parameter. While the original implementation included both -wd {subdomain} and -wd {self.site}, the updated command only retains -wd {self.site}. This omission removes wildcard detection for the specific subdomain being tested, which can lead to false positives from wildcard DNS responses.
main.py#L644-L652
Lines 644 to 652 in 75b9aa1
Was this report helpful? Give feedback by reacting with 👍 or 👎
Co-authored-by: ek <ek@drimble.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
_recursive_dnsx_bruteforcemethod to enhance reliability, performance, and resource management.The previous implementation suffered from race conditions due to shared file I/O, inefficient memory usage from duplicate data, and lacked robust error handling and progress tracking. This refactor addresses these issues by introducing thread-safe operations, proper deduplication, adaptive threading, and comprehensive resource management.