TWHeaders: fallback to valid Twitter color for custom selections #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When colorID is 7 or 8 (custom colors), set Twitter's internal primary color to a valid fallback (blue, id 1) while preserving the custom selection elsewhere. This avoids passing unsupported IDs to native components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’ve been developing an internal tool to help identify valuable, unmerged commits across downstream forks.
Using this tool, we found a commit in NeoFreeBird/tweak that adds a fallback behavior for custom colors (7/8), so Twitter’s internal
primaryColoris never set to an unsupported value. This prevents invalid/unknown color IDs from being applied to Twitter native components while still keeping the user’s custom choice.We’re submitting this PR in case it’s helpful for your project. If this change isn’t something you’d like to include, we’d still really appreciate any feedback or suggestions — it would help us improve the tool and our selection process.
Also, just to clarify: commits surfaced by the tool are always manually reviewed and validated, and this PR was created by a human after review, not generated or submitted automatically by AI.
Thanks a lot for your time and review!