-
Notifications
You must be signed in to change notification settings - Fork 35
read profile from config.yaml and multiple file generating #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
73b48d8 to
b950710
Compare
|
Hey, thanks for the PR! I am hesitant to merge it, though. From a software engineering standpoint, these changes make sense and improve things, no doubt. But I feel they also bring a certain weight and lower the accessibility of this project. Currently, I believe everyone who can manage to install Python will be able to download With the changes you suggest, this barrier is raised. Someone wanting to generate their own threads will now additionally have to install a dependency and download and rename/copy another file (though the rename/copy could maybe be avoided). That is, if they don't go the proper and even more complicated route of cloning the repo and using Poetry, etc. I know this may sound like childsplay to a semi-seasoned Python dev but I fear that to many in the "target demographic" of this project - the maker community - this might reduce its attractiveness significantly. I hope I got my point across and would love to hear what your thoughts on my concerns are. |
|
Your suggestion is very reasonable, I can replace the YAML file parser with the built-in JSON parser or other simpler format ,reducing the cost of non-Python writers, and keeping the original User's experience I wanted a way to generate custom threads without a fork, so I provided a way to read the configuration file via parameters. Reading the default configuration file and generating the configuration by executing ”python main.py” should also be supported. |
|
@BalzGuenat this pr is ready for reviewing |
| @@ -0,0 +1,3 @@ | |||
| config.yaml | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Pull Request Description
Title: Add CLI Argument for Config File Path, Verbose Logging, and Project Configuration
Description:
This pull request introduces several enhancements and configurations to the project:
Command-Line Argument for Config File Path:
./config.yaml.Verbose Logging:
-vor--verbosecommand-line argument to enable verbose logging.DEBUG, providing more detailed logs for debugging purposes.Project Configuration with
pyproject.toml:pyproject.tomlfile to specify the project requirements, including the Python version and dependencies.>=3.10and includespyyamlas a dependency.tests
the V3.xml is generated by new implemented python script, 100% equal to origin one