Skip to content

added AuthorNotFoundException #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reachanip wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added AuthorNotFoundException #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/swiz/bcs/controller/GlobalControllerAdvice.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.swiz.bcs.controller;

import com.swiz.bcs.exception.AuthorNotFoundException;
import com.swiz.bcs.exception.BookNotFoundException;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
Expand All @@ -13,5 +14,9 @@ public class GlobalControllerAdvice {
public ResponseEntity<String> handleBookNotFoundException(BookNotFoundException e){
return new ResponseEntity<>(e.getMessage(), HttpStatus.NOT_FOUND);
}
@ExceptionHandler(AuthorNotFoundException.class)
public ResponseEntity<String> handleAuthorNotFoundException(AuthorNotFoundException e){
return new ResponseEntity<>(e.getMessage(), HttpStatus.NOT_FOUND);
}

}
8 changes: 8 additions & 0 deletions src/main/java/com/swiz/bcs/exception/AuthorNotFoundException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package com.swiz.bcs.exception;

public class AuthorNotFoundException extends RuntimeException{
public AuthorNotFoundException(String message){
super(message);
}
}

4 changes: 3 additions & 1 deletion src/main/java/com/swiz/bcs/service/AuthorService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import com.swiz.bcs.dto.AuthorDTO;
import com.swiz.bcs.entity.Author;
import com.swiz.bcs.exception.AuthorNotFoundException;
import com.swiz.bcs.repository.AuthorRepository;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Service;
Expand All @@ -28,7 +29,8 @@ public List<Author> findAllAuthors() {
}

public Author findAuthorById(Long id) {
return authorRepository.findById(id).orElse(null);
return authorRepository.findById(id)
.orElseThrow(() -> new AuthorNotFoundException("Author not found with ID: "+id));
}

// Other author-related operations
Expand Down