Skip to content

Add collector for Cheshire East Council #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BadgerHobbs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add collector for Cheshire East Council #95

BadgerHobbs wants to merge 2 commits into from

Conversation

@BadgerHobbs
Copy link
Owner

@BadgerHobbs BadgerHobbs commented Jan 3, 2026

Summary

This PR adds a new bin collection data collector for Cheshire East Council.

  • Implements ICollector interface
  • Adds integration tests
  • Successfully tested with example postcode from issue

Closes #83

Test Summary

 ==================== Test Summary ====================
 
 --------------------- Collector ----------------------
 
 Cheshire East Council
 
 ------------------- Addresses (34) -------------------
 
 - 3 BRIERLEY STREET, CREWE, CW1 2AY, 100010070040
 - 4 BRIERLEY STREET, CREWE, CW1 2AY, 100010070041
 - 6 BRIERLEY STREET, CREWE, CW1 2AY, 100010070042
 - 8 BRIERLEY STREET, CREWE, CW1 2AY, 100010070043
 - 10 BRIERLEY STREET, CREWE, CW1 2AY, 100010070044
 - ...
 
 ------------------- Bin Days (23) --------------------
 
 - 13/01/2026 (1 bins):
   - Recycling
 
 - 27/01/2026 (1 bins):
   - Recycling
 
 - 10/02/2026 (1 bins):
   - Recycling
 
 - 24/02/2026 (1 bins):
   - Recycling
 
 - 10/03/2026 (1 bins):
   - Recycling
 
 - 24/03/2026 (1 bins):
   - Recycling
 
 - 07/04/2026 (1 bins):
   - Recycling
 
 - 21/04/2026 (1 bins):
   - Recycling
 
 - 05/05/2026 (1 bins):
   - Recycling
 
 - 19/05/2026 (1 bins):
   - Recycling
 - ...
 
 ======================================================

Generated automatically by Codex CLI

@BadgerHobbs BadgerHobbs mentioned this pull request Jan 3, 2026
Open
@gemini-code-assist

This comment was marked as outdated.

Sign in to view
gemini-code-assist[bot]

This comment was marked as outdated.

Sign in to view

@BadgerHobbs BadgerHobbs force-pushed the collector/CheshireEastCouncil-issue-83-1767482447 branch from cbecbff to ede3996 Compare January 3, 2026 23:41
Repository owner deleted a comment from github-actions bot Jan 3, 2026
@BadgerHobbs BadgerHobbs force-pushed the collector/CheshireEastCouncil-issue-83-1767482447 branch 2 times, most recently from 93af956 to 13b18d0 Compare January 10, 2026 00:59
@BadgerHobbs
Copy link
Owner Author

BadgerHobbs commented Jan 10, 2026

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 10, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds a new collector for Cheshire East Council and an integration test, which is great. The implementation is solid and mostly follows the project's style guide.

I've left a few comments regarding minor style guide violations, such as missing trailing commas in object initializers and the missing null-forgiving operator on regex matches. I've also suggested a small refactoring to reduce code duplication between GetAddresses and GetBinDays for better maintainability.

Additionally, a markdown file (.agent/prompts/fix-pr-comment.md) was added which seems unrelated to the collector implementation. I've made a minor suggestion there, but it might be worth checking if this file was intended to be part of this PR.

Overall, great work on the new collector!

@BadgerHobbs
Add collector for CheshireEastCouncil
fe67a0a 
Closes #83

Generated with Codex CLI
@BadgerHobbs BadgerHobbs force-pushed the collector/CheshireEastCouncil-issue-83-1767482447 branch from 13b18d0 to fe67a0a Compare January 17, 2026 00:17
BadgerHobbs
BadgerHobbs commented Jan 17, 2026
View reviewed changes
@BadgerHobbs @claude
Address PR #95 review comments
37d4782 
- Remove redundant postcode formatting (already formatted)
- Remove timestamp cache-busting parameters (not required)
- Remove URI escaping (not needed)
- Simplify Address object to use Property and Postcode only
- Expect postcode and cookies to be provided (remove conditionals)
- Use postcode from request parameter, not parsed address parts
- Fix null-forgiving operators per style guide (on Matches, not Groups)
- Add comment for onelineAddress building logic

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@BadgerHobbs
Copy link
Owner Author

BadgerHobbs commented Jan 27, 2026

Quick investigation into the return of only recycling. Seems to be that's all which is returned. Kind of odd.

image

@BadgerHobbs BadgerHobbs added ready for deployment Implementation ready for deployment new collector Request for a new collector to be supported labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new collector Request for a new collector to be supported ready for deployment Implementation ready for deployment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cheshire East Council

1 participant

@BadgerHobbs