Add collector for Tunbridge Wells Borough Council#91
Add collector for Tunbridge Wells Borough Council#91github-actions[bot] wants to merge 5 commits intomainfrom
Conversation
117b39e to
66dfcee
Compare
b432790 to
681f40a
Compare
Closes #89 Generated with Codex CLI
681f40a to
fb0020e
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new collector for Tunbridge Wells Borough Council. The implementation correctly follows the multi-step process required by the council's API, using AchieveForms. The code is well-structured and includes integration tests as required.
My review focuses on improving adherence to the repository's C# style guide and enhancing maintainability. I've pointed out several places where trailing commas are missing in object initializers, which is a requirement of the style guide. I also suggest using a named capture group for regex matching to improve readability. Additionally, I've identified an opportunity to reduce code duplication by extracting the creation of the initial client-side request into a helper method.
Overall, this is a solid contribution. Addressing these minor points will make the code even cleaner and more consistent with the project's standards.
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
- Extract duplicate ClientSideRequest creation into CreateInitialRequest helper method - Use named capture group 'sessionId' instead of numeric group index for better readability Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
9046da3 to
e3328ef
Compare
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/TunbridgeWellsBoroughCouncil.cs
Show resolved
Hide resolved
- Remove single-use constants (_addressLookupId, _collectionsLookupId) - Remove empty/null properties from request bodies - Remove duplicate postcode formatting in GetAddresses - Remove unnecessary fields from GetBinDays request body - Move SessionIdRegex above methods Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Summary
This PR adds a new bin collection data collector for Tunbridge Wells Borough Council.
ICollectorinterfaceCloses #89
Test Summary
Generated automatically by Codex CLI