Skip to content

Add collector for Tunbridge Wells Borough Council#91

Open
github-actions[bot] wants to merge 5 commits intomainfrom
collector/TunbridgeWellsBoroughCouncil-issue-89
Open

Add collector for Tunbridge Wells Borough Council#91
github-actions[bot] wants to merge 5 commits intomainfrom
collector/TunbridgeWellsBoroughCouncil-issue-89

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 3, 2026

Summary

This PR adds a new bin collection data collector for Tunbridge Wells Borough Council.

  • Implements ICollector interface
  • Adds integration tests
  • Successfully tested with example postcode from issue

Closes #89

Test Summary

==================== Test Summary ====================

--------------------- Collector ----------------------

Tunbridge Wells Borough Council

------------------- Addresses (18) -------------------

- 1 Lurkins Rise, Goudhurst, Cranbrook, TN17 1ED, TN17 1ED, 100061189079
- 2 Lurkins Rise, Goudhurst, Cranbrook, TN17 1ED, TN17 1ED, 100061189080
- 3 Lurkins Rise, Goudhurst, Cranbrook, TN17 1ED, TN17 1ED, 100061189081
- 4 Lurkins Rise, Goudhurst, Cranbrook, TN17 1ED, TN17 1ED, 100061189082
- 5 Lurkins Rise, Goudhurst, Cranbrook, TN17 1ED, TN17 1ED, 100061189083
- ...

-------------------- Bin Days (7) --------------------

- 07/01/2026 (3 bins):
 - Recycling Bin
 - Paper Recycling
 - Food Waste

- 13/01/2026 (2 bins):
 - General Waste
 - Food Waste

- 14/01/2026 (1 bins):
 - Garden Waste

- 20/01/2026 (3 bins):
 - Recycling Bin
 - Paper Recycling
 - Food Waste

- 27/01/2026 (2 bins):
 - General Waste
 - Food Waste

- 28/01/2026 (1 bins):
 - Garden Waste

- 03/02/2026 (3 bins):
 - Recycling Bin
 - Paper Recycling
 - Food Waste

Generated automatically by Codex CLI

@BadgerHobbs BadgerHobbs force-pushed the main branch 4 times, most recently from 117b39e to 66dfcee Compare January 4, 2026 01:40
@BadgerHobbs BadgerHobbs force-pushed the collector/TunbridgeWellsBoroughCouncil-issue-89 branch from b432790 to 681f40a Compare January 10, 2026 00:38
@BadgerHobbs BadgerHobbs force-pushed the collector/TunbridgeWellsBoroughCouncil-issue-89 branch from 681f40a to fb0020e Compare January 10, 2026 00:58
@BadgerHobbs
Copy link
Owner

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new collector for Tunbridge Wells Borough Council. The implementation correctly follows the multi-step process required by the council's API, using AchieveForms. The code is well-structured and includes integration tests as required.

My review focuses on improving adherence to the repository's C# style guide and enhancing maintainability. I've pointed out several places where trailing commas are missing in object initializers, which is a requirement of the style guide. I also suggest using a named capture group for regex matching to improve readability. Additionally, I've identified an opportunity to reduce code duplication by extracting the creation of the initial client-side request into a helper method.

Overall, this is a solid contribution. Addressing these minor points will make the code even cleaner and more consistent with the project's standards.

- Extract duplicate ClientSideRequest creation into CreateInitialRequest helper method
- Use named capture group 'sessionId' instead of numeric group index for better readability

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@BadgerHobbs BadgerHobbs force-pushed the collector/TunbridgeWellsBoroughCouncil-issue-89 branch from 9046da3 to e3328ef Compare January 11, 2026 15:10
- Remove single-use constants (_addressLookupId, _collectionsLookupId)
- Remove empty/null properties from request bodies
- Remove duplicate postcode formatting in GetAddresses
- Remove unnecessary fields from GetBinDays request body
- Move SessionIdRegex above methods

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@BadgerHobbs BadgerHobbs added ready for deployment Implementation ready for deployment new collector Request for a new collector to be supported labels Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new collector Request for a new collector to be supported ready for deployment Implementation ready for deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tunbridge Wells Borough Council

2 participants