Strip incidents logic from the API

BinDays.Api/Controllers/CollectorsController.cs

@@ -1,10 +1,9 @@
-namespace BinDays.Api.Controllers
+namespace BinDays.Api.Controllers
 {
 	using BinDays.Api.Collectors.Exceptions;
 	using BinDays.Api.Collectors.Models;
 	using BinDays.Api.Collectors.Services;
 	using BinDays.Api.Collectors.Utilities;
-	using BinDays.Api.Incidents;
 	using Microsoft.AspNetCore.Http;
 	using Microsoft.AspNetCore.Mvc;
 	using Microsoft.Extensions.Caching.Distributed;
@@ -32,11 +31,6 @@ public class CollectorsController : ControllerBase
 		/// </summary>
 		private readonly ILogger<CollectorsController> _logger;
 
-		/// <summary>
-		/// Store for recording failed incidents.
-		/// </summary>
-		private readonly IIncidentStore _incidentStore;
-
 		/// <summary>
 		/// Distributed cache for storing responses.
 		/// </summary>
@@ -53,13 +47,11 @@ public class CollectorsController : ControllerBase
 		/// <param name="collectorService">Service for retrieving collector information.</param>
 		/// <param name="logger">Logger for the controller.</param>
 		/// <param name="cache">Distributed cache for storing responses.</param>
-		/// <param name="incidentStore">Store for recording failed incidents.</param>
-		public CollectorsController(CollectorService collectorService, ILogger<CollectorsController> logger, IDistributedCache cache, IIncidentStore incidentStore)
+		public CollectorsController(CollectorService collectorService, ILogger<CollectorsController> logger, IDistributedCache cache)
 		{
 			_collectorService = collectorService;
 			_logger = logger;
 			_cache = cache;
-			_incidentStore = incidentStore;
 		}
 
 		/// <summary>
@@ -73,7 +65,7 @@ private static string FormatPostcodeForCacheKey(string postcode)
 		}
 
 		/// <summary>
-		/// Attempts to retrieve and deserialize an object from the cache. 
+		/// Attempts to retrieve and deserialize an object from the cache.
 		/// Handles deserialization errors by evicting the bad cache entry.
 		/// </summary>
 		/// <typeparam name="T">The type to deserialize into.</typeparam>
@@ -176,7 +168,6 @@ public IActionResult GetCollector(string postcode, [FromBody] ClientSideResponse
 			catch (Exception ex)
 			{
 				_logger.LogError(ex, "An unexpected error occurred while retrieving collector for postcode: {Postcode}.", postcode);
-				RecordIncident(null, IncidentOperation.GetCollector, ex);
 				return StatusCode(StatusCodes.Status500InternalServerError, "An unexpected error occurred while fetching the collector for the specified postcode. Please try again later.");
 			}
 		}
@@ -231,7 +222,6 @@ public IActionResult GetAddresses(string govUkId, string postcode, [FromBody] Cl
 			catch (Exception ex)
 			{
 				_logger.LogError(ex, "An unexpected error occurred while retrieving addresses for gov.uk ID: {GovUkId}, postcode: {Postcode}.", govUkId, postcode);
-				RecordIncident(govUkId, IncidentOperation.GetAddresses, ex);
 				return StatusCode(StatusCodes.Status500InternalServerError, "An unexpected error occurred while fetching addresses. Please try again later.");
 			}
 		}
@@ -297,70 +287,8 @@ public IActionResult GetBinDays(string govUkId, string postcode, string uid, [Fr
 			catch (Exception ex)
 			{
 				_logger.LogError(ex, "An unexpected error occurred while retrieving bin days for gov.uk ID: {GovUkId}, postcode: {Postcode}, UID: {Uid}.", govUkId, postcode, uid);
-				RecordIncident(govUkId, IncidentOperation.GetBinDays, ex);
 				return StatusCode(StatusCodes.Status500InternalServerError, "An unexpected error occurred while fetching bin days. Please try again later.");
 			}
 		}
-
-		/// <summary>
-		/// Records an unexpected incident for diagnostics.
-		/// </summary>
-		/// <param name="govUkId">The collector identifier, if known.</param>
-		/// <param name="operation">The operation that was being performed.</param>
-		/// <param name="exception">The triggering exception.</param>
-		private void RecordIncident(string? govUkId, IncidentOperation operation, Exception exception)
-		{
-			var normalisedGovUkId = string.IsNullOrWhiteSpace(govUkId) ? string.Empty : govUkId.Trim().ToLowerInvariant();
-
-			var incident = new IncidentRecord
-			{
-				IncidentId = Guid.NewGuid(),
-				GovUkId = normalisedGovUkId,
-				OccurredUtc = DateTime.UtcNow,
-				Category = Classify(exception),
-				Operation = operation,
-				MessageHash = ComputeHash(exception),
-				ExceptionType = exception.GetType().FullName ?? exception.GetType().Name,
-			};
-
-			try
-			{
-				_incidentStore.RecordIncident(incident);
-			}
-			catch (Exception storeException)
-			{
-				_logger.LogError(storeException, "Failed to record incident for collector {GovUkId}.", normalisedGovUkId);
-			}
-		}
-
-		/// <summary>
-		/// Classifies an exception into an incident category.
-		/// </summary>
-		/// <param name="exception">The exception to classify.</param>
-		/// <returns>The incident category.</returns>
-		private static IncidentCategory Classify(Exception exception)
-		{
-			return exception switch
-			{
-				HttpRequestException or TimeoutException or TaskCanceledException => IncidentCategory.CollectorFailure,
-				System.Text.Json.JsonException or FormatException or InvalidOperationException => IncidentCategory.IntegrationChanged,
-				_ => IncidentCategory.SystemFailure,
-			};
-		}
-
-		/// <summary>
-		/// Computes a deterministic hash for an exception.
-		/// </summary>
-		/// <param name="exception">The exception to hash.</param>
-		/// <returns>A hexadecimal hash string.</returns>
-		private static string ComputeHash(Exception exception)
-		{
-			var payload = Encoding.UTF8.GetBytes(
-				$"{exception.GetType().FullName}|{exception.TargetSite?.ToString() ?? "UnknownTarget"}|{exception.Message}"
-			);
-			var hash = SHA256.HashData(payload);
-
-			return Convert.ToHexString(hash);
-		}
 	}
 }