Add collector for Salford City Council

[moley-bot]

Summary

This PR adds a new bin collection data collector for Salford City Council.

• Implements ICollector interface
• Adds integration tests
• Successfully tested with example postcode from issue

Closes #132

Test Summary

 ==================== Test Summary ====================
 
 --------------------- Collector ----------------------
 
 Salford City Council
 
 ------------------- Addresses (38) -------------------
 
 - FLAT 1, MOORSIDE LODGE, MOORSIDE ROAD, SWINTON, MANCHESTER, M27 9LF, M27 9LF, 100012471143
 - 1 MOORSIDE LODGE, MOORSIDE ROAD, SWINTON, MANCHESTER, M27 9LF, M27 9LF, 100012471143
 - FLAT 2, MOORSIDE LODGE, MOORSIDE ROAD, SWINTON, MANCHESTER, M27 9LF, M27 9LF, 100012471144
 - 2 MOORSIDE LODGE, MOORSIDE ROAD, SWINTON, MANCHESTER, M27 9LF, M27 9LF, 100012471144
 - FLAT 3, MOORSIDE LODGE, MOORSIDE ROAD, SWINTON, MANCHESTER, M27 9LF, M27 9LF, 100012471145
 - ...
 
 --------------------- Bin Types ----------------------
 
 - Food and Garden Waste (Pink)
 - Glass, Cans and Plastics (Brown)
 - Household Waste (Black)
 - Paper and Cardboard (Blue)
 
 ------------------- Bin Days (26) --------------------
 
 - 06/02/2026 (2 bins):
   - Food and Garden Waste (Pink)
   - Paper and Cardboard (Blue)
 
 - 13/02/2026 (2 bins):
   - Food and Garden Waste (Pink)
   - Glass, Cans and Plastics (Brown)
 
 - 20/02/2026 (3 bins):
   - Household Waste (Black)
   - Food and Garden Waste (Pink)
   - Paper and Cardboard (Blue)
 
 - 27/02/2026 (2 bins):
   - Food and Garden Waste (Pink)
   - Glass, Cans and Plastics (Brown)
 
 - 06/03/2026 (2 bins):
   - Food and Garden Waste (Pink)
   - Paper and Cardboard (Blue)
 
 - 13/03/2026 (3 bins):
   - Food and Garden Waste (Pink)
   - Glass, Cans and Plastics (Brown)
   - Household Waste (Black)
 
 - 20/03/2026 (2 bins):
   - Food and Garden Waste (Pink)
   - Paper and Cardboard (Blue)
 
 - 27/03/2026 (2 bins):
   - Food and Garden Waste (Pink)
   - Glass, Cans and Plastics (Brown)
 
 - 03/04/2026 (3 bins):
   - Household Waste (Black)
   - Food and Garden Waste (Pink)
   - Paper and Cardboard (Blue)
 
 - 10/04/2026 (2 bins):
   - Food and Garden Waste (Pink)
   - Glass, Cans and Plastics (Brown)
 - ...
 
 ======================================================

---

Generated automatically by Moley-Bot using Codex CLI

[BadgerHobbs]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new collector for Salford City Council, which is a great addition and adheres well to the project's style guide. However, two instances of missing URL encoding were identified when constructing requests to the council's API. This could lead to parameter injection vulnerabilities if user-supplied data (like postcodes) or externally-sourced data (like UPRNs) contain special characters. Remediation involves using proper URL encoding methods for all dynamic parameters in HTTP requests, specifically for the GetAddresses request body.

[moley-bot]

Claude finished @BadgerHobbs's task in 5m 13s —— View job

---

✅ Task complete

Todo List:

• Read repository guidelines
• Read SalfordCityCouncil.cs
• Check style guide
• Analyze keys
• Remove unnecessary keys
• Commit and push changes

Changes made:

Removed the second (descriptive) key from each bin type in SalfordCityCouncil.cs per the style guide requirement (.gemini/styleguide.md:429-443) to "only include keys that are actually matched against the data source."

Updated Keys:

• [ "Black bin", "Domestic Waste" ] → [ "Black bin" ]
• [ "Pink lidded bin", "Food and Garden Waste" ] → [ "Pink lidded bin" ]
• [ "Blue bin", "Paper and Card" ] → [ "Blue bin" ]
• [ "Brown bin", "Bottle and Can" ] → [ "Brown bin" ]

Rationale: ICS calendar SUMMARY fields typically use concise, color-based names rather than verbose descriptions. Keeping only the color-based keys aligns with the repository's style guide and reduces unnecessary code.

Commit: e09a8f8

---

|