Add collector for East Devon District Council#114
Add collector for East Devon District Council#114moley-bot[bot] wants to merge 4 commits intomainfrom
Conversation
Closes #24 Generated with Codex CLI by Moley-Bot
Formatted by Moley-Bot
BinDays.Api.Collectors/Collectors/Councils/EastDevonDistrictCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/EastDevonDistrictCouncil.cs
Outdated
Show resolved
Hide resolved
BinDays.Api.Collectors/Collectors/Councils/EastDevonDistrictCouncil.cs
Outdated
Show resolved
Hide resolved
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new collector for East Devon District Council, complete with integration tests. The implementation is solid and adheres well to the project's architecture for multi-step collectors.
My review focuses on a few minor style guide improvements, such as adding trailing commas and making bin names more descriptive, which will enhance code consistency. I've also identified a potential fragility in the date parsing logic and suggested a more robust regular expression-based approach.
Overall, this is a great contribution. The code is clean, well-structured, and the new collector is successfully tested.
BinDays.Api.Collectors/Collectors/Councils/EastDevonDistrictCouncil.cs
Outdated
Show resolved
Hide resolved
|
@claude Resolve PR comments, making sure to test new changes and check against style guide, making amendments as required. |
|
Claude finished @BadgerHobbs's task in 2m 15s —— View job Resolving PR Comments ✅I've successfully addressed all the review comments from the PR reviews: Changes Made
Testing NoteI was unable to run build and test commands due to permission restrictions. The CI/CD pipeline will validate these changes when the PR is updated. All changes follow the repository's style guide and should pass automated checks. Commit: |
- Update bin names to be more descriptive (Paper, Glass & Cardboard Recycling) - Remove unnecessary postcode URL encoding - Remove unnecessary content variable - Add trailing commas and proper formatting for Headers dictionaries - Replace fragile Split-based date parsing with Regex for robustness Co-authored-by: Andrew Riggs <BadgerHobbs@users.noreply.github.com>
BinDays.Api.Collectors/Collectors/Councils/EastDevonDistrictCouncil.cs
Outdated
Show resolved
Hide resolved
- Updated regex to capture only month name (year optional) - Replaced DateOnly.ParseExact with ParseDateInferringYear extension - Handles year transitions correctly (e.g., Dec -> Jan boundary) - More resilient to website HTML format changes - Follows style guide recommendation for date parsing Co-authored-by: Andrew Riggs <BadgerHobbs@users.noreply.github.com>
Summary
This PR adds a new bin collection data collector for East Devon District Council.
ICollectorinterfaceCloses #24
Test Summary
Generated automatically by Moley-Bot using Codex CLI