Use test helpers and fixtures from b2sdk #1110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlech-reef
reviewed
Aug 8, 2025
| ROOT_PATH = pathlib.Path(__file__).parent.parent.parent | ||
|
|
||
|
|
||
| pytest_plugins = ['b2sdk.v3.testing'] |
kacper-wolkiewicz-reef
changed the title
kacper-wolkiewicz-reef
changed the title
* origin/master: Redesign seed generation in CI Avoid failing on missing extra dependencies in license command Publish Linux ARM binaries Test Linux ARM binaries Add changelog.d entry Add ubuntu-24.04-arm to the CI Redesign url parsing to handle values with leading / and trailing special chars release 4.4.1 Pin docutils version release 4.4.0
|
✅ LGTM |
mlech-reef
suggested changes
Aug 23, 2025
Contributor
mlech-reef
left a comment
mlech-reef
left a comment
There was a problem hiding this comment.
- You haven't updated .github/workflows/ci.yml. Please keep a special attention to contains(fromJSON('["3.8", "pypy3.10", "3.13"]'). It supposed to run all the integration tests that require secrets in the lowest and highest supported version available (for cpython).
- In
CONTRIBUTING.mdtest-3.8is mentioned. Please update.
Contributor
There was a problem hiding this comment.
Please remove all instances of python_version >= '3.9' specifier from this file. They are redundant now.
Contributor
There was a problem hiding this comment.
Please remove python_version >= '3.8' as well
test/integration/conftest.py
Outdated
| @pytest.fixture(scope='session') | ||
| def b2_api( | ||
| def bucket_name_prefix(): | ||
| return bucket_name_part(8) |
Contributor
There was a problem hiding this comment.
Why removing clitst from the prefix?
- Add clitst prefix to bucket names in tests
kacper-wolkiewicz-reef
force-pushed
the
B2-171-tests-commons
branch
from
74410ad to
7557405
Compare
mlech-reef
approved these changes
Aug 26, 2025
This was referenced Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, because PR in b2sdk must be pulled first (Backblaze/b2-sdk-python#545) and library version bumped. Otherwise ready for a review.