Update Windows code signing to use KeyLocker #1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not sure what's going on with these failures but I'm looking into it. |
Contributor
Author
|
It looks like some tests are failing because in some cases the list of buckets that an app key is restricted to is coming back in a different order; ['clitstgetq93ee73cj9ni6m9b2sv0wng0evk5qorhksupl72-upmo6xp27g8cct',
'clitstgetq93ee2976bia7oll2y8meyssvhhcvq54yu-z2n0r2w5b--xcozbkhn']vs ['clitstgetq93ee2976bia7oll2y8meyssvhhcvq54yu-z2n0r2w5b--xcozbkhn',
'clitstgetq93ee73cj9ni6m9b2sv0wng0evk5qorhksupl72-upmo6xp27g8cct'] |
Collaborator
|
Hey @b-boogaard, I'm currently working on the fix for the tests problem you've mentioned. |
b-boogaard
force-pushed
the
bboogaard/update-code-signing
branch
from
121a06d to
777847c
Compare
Contributor
Author
|
Thanks @olzhasar-reef! |
Contributor
Author
|
The multi-bucket issue is resolved now 🎉 However, it's looking like python 3.8 is having a couple problems with some |
byrdsteve
reviewed
Jul 25, 2025
Co-authored-by: Stephen Byrd <30883208+byrdsteve@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the GitHub actions in
cd.ymlto use DigiCert's KeyLocker and cloud based signing solutions for increased code signing certificate security.