[Windows] TensorFlow support #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compilation errors with workaround from: tensorflow/tensorflow#45823 (comment) Set warning level w3 to threat C4596 as warning. Load the dll in pyrender_tensorflow when using Windows. Remove checks that are supposed to ignore tensorflow on Windows. Fix small bug in test_g_buffer: target_depth size was (256,256) not (256,256,1). Tested with Tensorflow 2.9.1, CUDA 11.2, and Visual Studio 2019, Version 16.7.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I managed to compile the tensorflow custom_ops on Windows using this workaround and ignoring the C4596 with warning level /W3. I compiled with Visual Studio 2019 (Version 16.7.5, MSVC 19.27.29112), TensorFlow 2.9.1, and CUDA 11.2. The tests_tensorflow scripts seem to work as intended.
This solves #117.
Other changes: