fixed asyncio bug #191
Merged
fixed asyncio bug #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaboucheOne
requested changes
Aug 23, 2025
| @@ -46,7 +46,7 @@ def read_arguments() -> argparse.Namespace: | |||
| if args.command == TOOL_NAME_MIGRATE_STUDENT: | |||
| asyncio.run(migrate_discord_students.main(arguments=sys.argv[2:])) | |||
| elif args.command == TOOL_NAME_UPDATE_STUDENTS_LIST: | |||
Owner
There was a problem hiding this comment.
I've found the cause of the problem. The main of update_students_list is not async (and the whole code of this file too btw).
I think the real patch is to convert https://github.com/BaboucheOne/BuggyBot/blob/main/tools/update_students_list.py as a real async script.
Contributor
Author
There was a problem hiding this comment.
Sure, if you do it I don't mind, I just chose the easiest way to fix the bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was caused by awaiting a synchronous function with
asyncio.run.Closes #171