-
Notifications
You must be signed in to change notification settings - Fork 0
Add Digital Asset Links support to Cloudflared add-on #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
|
@copilot i want to drop support for all languages other than English; i also want you to add unit tests to all configuration options with comprehensive test cases, and integration tests run via github actions to test that the containers should start without any issue under correct configuration. follow best practices to ensure quality control/gate |
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Completed the requested updates: non-English translations removed, pytest-based config/translation coverage added, and CI now runs tests plus a tagged smoke-test container start. Commit: e9f906f. |
|
@copilot it's fine to use pytest for testing but the main goal is that these bash functions and logics perform what they intend to do and are bug-free across a comprehensive set of inputs. while YAML formatting quality check is already covered by the linter |
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Added bash-focused DAL validation tests that exercise the script logic across scheme/path/port/dedupe cases and updated the runner to allow isolated execution. Commit: 7e763a6. |
|
@copilot 1. please address this issue; we only have GHCR access and even so you should not add an additional image tag for the purpose of running your smoke test; the existing tags should be enough, or you could pull the image from the local dockerd; logs: Run IMAGE_TAG="hass-cloudflared-smoke:aadcf2007aaa7e9056cc8a24d10770031030f17c-amd64" Run 'docker run --help' for more information |
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Updated CI to use local image IDs (no extra tags), switched pytest setup to uv + pinned Python, and replaced mocks with pinned bashio download + checksum/SSL/path checks. Commit: 8c1d5b1. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot to clarify, only actions from actions/ and docker/ are trustworthy and don't need to have their commit hash pinned; other actions are not exempted. also when i say "using uv" i mean a modern uv-managed python project with pyproject.toml properly set up for testing, not to use uv in the runtime to install pip libraries; uv should still be the only manager of the python venv, but it's not used like that. follow best practices. |
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Adjusted action pinning per policy, introduced a uv-managed pyproject with pytest pinned, and updated CI to use uv sync/run. Commit: 528977a. |
|
@copilot please address issues with wrong uv usage patterns. in the CI file, please use the setup-uv actions test-pytest: the uv.lock file is missing and is required for the uv command to work. the bashio should be loaded via git clone, not an HTTP request to the code load endpoint. def run_share(tmp_path, config_path, *, status_json=None, extra_env=None): please address the above issues following best practices |
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Co-authored-by: MinecraftFuns <25814618+MinecraftFuns@users.noreply.github.com>
Switched CI to setup-uv with pinned version, added uv.lock, and updated tests to clone bashio via git with pinned checkout plus error reporting. Commit: b7e8335. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Add a
digital_asset_links_sitesconfiguration option that generates a DAL JSON file for HTTPS origins and serves it safely from the add-on, with Cloudflare tunnel routing guidance.digital_asset_links_sitesto config schema and English translation with strict HTTPS origin validation, de-duplication, and stable ordering.${DAL_ROOT}/www/.well-known/assetlinks.jsonand BusyBoxhttpd.confwithapplication/jsonMIME mapping under/data/digital-asset-links.httpdon127.0.0.1:36555and insert a/.well-known/*ingress rule for locally managed tunnels; documented remote-managed routing expectations.pyproject.tomlwith pinned pytest anduv.lock, and updated CI to use setup-uv withuv sync/uv runplus a pinned Python version.Example config:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.