Sync upstream #18
Open
Sync upstream #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ename duplication avoidance
… will be always more created nodes/gamesobjects
…sed for one texture, the textures will be duplicated
… in animationpointer import/export, fixes when only offset exist
…ped-on-opengl' into dev
…ions-and-ktx-mipmap-fix' into dev
…ready-correct-names' into dev
…convert it to VEC2
… extend the Importer Inspector with new Info tab
…formations' into dev
…ort-settings' into dev
…ttributes' into dev
…t first library import
…hangelog change entry
…r using ShouldNodeExport callback
…nityGltf version should be used with Unity 2020.3
# Conflicts: # Runtime/Scripts/GLTFSceneExporter.cs # Runtime/Shaders/ShaderGraph/PBRGraph.shadergraph
wschnepp
commented
Mar 18, 2025
Comment on lines
+26
to
+44
| string baseName = Path.GetFileNameWithoutExtension(name); | ||
| var i = 1; | ||
| newName = $"{baseName}-{i}{extension}"; | ||
| while (existingNames.Contains($"{baseName}-{i}{extension}")) | ||
| { | ||
| i++; | ||
| newName = $"{baseName}-{i}{extension}"; | ||
| } | ||
| } | ||
| else | ||
| { | ||
| var i = 1; | ||
| newName = $"{name}-{i}"; | ||
| while (existingNames.Contains($"{name}-{i}")) | ||
| { | ||
| i++; | ||
| newName = $"{name}-{i}"; | ||
| } | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
why not local method
wschnepp
commented
Mar 18, 2025
Comment on lines
+57
to
+61
| if (!material) | ||
| { | ||
| material = new Material(shader); | ||
| material.SetOverrideTag("RenderType", "Transparent"); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync upstream changes into our fork.
TODO:
KHR_node_visibilityseems to make the visibility track stuff obsolete. Should test