Asset patching fix #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic to itself to avoid multiple mods doing partition modifications.
…nto asset-patching-fix
…ding to specific necesities for some and just default values for some others. Now there are specific settings per map to allow a day duration and a starting hour for each. Fixed something in the VEHandler module, I think we don't want it to pulse when we are "fading into" Multiple attempts to fix water issues for night time, most of them seem have worked :) BUT FUCK YOU XP4_EARTHQUAKE., fuck you and your damn pond in US HQ. Of course the giant if in VEManager Client onLevelLoaded can be handled better and shorter... but I'm just don't care at this point.
…r clean/slow preset transitions.
…needed at least 1 custom preset for them, the rest can still use the default ones ). Cleanup of the sync event on level destroy.
Member
|
@MatiasPastori Thanks for the contribution, seems like you´ve been hard at work :) |
IllustrisJack
requested review from
MotorcycleEnjoyer and
Ori-Buhbut
and removed request for
IllustrisJack
bump version Removed some unnecessary properties from some presets.
…/VEManager into asset-patching-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking this could go straight to development branch actually.
No idea how RM is actually using it at this point after so many months. But no core logic should have changed substantially on the basic usage to just enable a preset specifically.
Have been using it at this current state for months with many other mods, no crashes, no issues.
The init config that uses the specific map presets can be modularized or passed to some kind of config. For my usage this was working great for the moment.
Open to refactors - enhancements.
Tinkered most assets I could for the maps that had issues with specific textures or backdrops for example, Seine Crossing.
Next in line is to fix the VEEditor, that is practically unusable at the moment, only working for some minor tests to force a preset via JSON.