Skip to content

Account#53

Open
julien-vendran wants to merge 10 commits intomainfrom
account
Open

Account#53
julien-vendran wants to merge 10 commits intomainfrom
account

Conversation

@julien-vendran
Copy link
Contributor

Adding the part of the management for the new account

Copy link
Member

@BrokenSwing BrokenSwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of things to modify / rework. Do not hesitate to use Buefy components for tables

methods: {
accept () {
console.log(this.mail);
if (confirm("Vous êtes sur le point de valider " + this.firstName + " " + this.lastName + "\n Voulez-vous confirmer ?")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm ? Really ? Actually I would suggest a checkable table https://buefy.org/documentation/table#checkable that allows to batch acceptation/removal. Take this comment as a global comment on NewUser.vue and BuilderNewUser.vue

Copy link
Member

@BrokenSwing BrokenSwing Aug 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, an other solution is to keep your first setup and use https://buefy.org/documentation/dialog/#confirm instead of native JS confirm

:validator='lastNameValidator'
required
/>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also want to know it's specialty (name and year), and BDE (assume BDE is Montpellier)

};
},
methods: {
checkUserRoles(usersRoles) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If defined, you should use it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants