Skip to content

Artist THD#2

Open
wittlsn wants to merge 6 commits intoBAMresearch:masterfrom
wittlsn:artist_thd
Open

Artist THD#2
wittlsn wants to merge 6 commits intoBAMresearch:masterfrom
wittlsn:artist_thd

Conversation

@wittlsn
Copy link

@wittlsn wittlsn commented Jun 22, 2023

Hello, greetings from the THD!

Nice to see that there is an official aRTist Python API!

I find the structure of the API and the calls not very intuitive. I have made a minimal suggestion for a more "pythonic" structure of the API. If the changes fit, I would also wrap the rest of the aRTist TCL/TK commands accordingly.

  1. More standard module structure: move the aRTist.py file to the module folder etc.
  2. Change to a more python PEP8 style: get_Obj_IDs() -> get_object_ids()
  3. Wrap the commands in python functions (see get_object_ids function )
  4. Add python class object of the hardware components (see Xray Source )

An example of the usage can be seen here: example_api.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant