Improve crash safety and resolve cfg path using GameDirectory#270
Open
wiruwiru wants to merge 2 commits intoB3none:masterfrom
Open
Improve crash safety and resolve cfg path using GameDirectory#270wiruwiru wants to merge 2 commits intoB3none:masterfrom
wiruwiru wants to merge 2 commits intoB3none:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes have been made to prevent potential crashes when using the !showspawns command, as described in issue #258. Although I haven't been able to reproduce the crash, the code has been updated to make it more robust.
Additionally, the logic used to create and resolve the configuration (
cfg) file path has been improved. The new implementation relies onGameDirectory, ensuring better compatibility across different server and folder structures. This addresses the problem described in issue #261.