Fix: Resolve theme attributes for dialog widgets on Android 9 #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Android 9 (API 28), dialog widgets like
DialogTitlecrash withUnsupportedOperationExceptionwhen resolving theme attribute references (e.g.,android:textColorLink). This happens becausecreateDialogWidgetView()usescreateWrappedContext()which doesn't include the dialog's theme.Fixes #35
Solution
Pass the
inflationContexttocreateDialogWidgetView()and create aContextThemeWrapperthat combines ViewPump's wrapped context with the dialog's theme:This preserves ViewPump's resource interception while enabling proper theme attribute resolution.
Changes
inflationContext: Contextparameter tocreateDialogWidgetView()themedSafeContextusingContextThemeWrapperthemedSafeContext