feat: add IaC conversion workflow for ACR to AMR migration#3
Open
suryaren wants to merge 1 commit intoAzureManagedRedis:mainfrom
Open
feat: add IaC conversion workflow for ACR to AMR migration#3suryaren wants to merge 1 commit intoAzureManagedRedis:mainfrom
suryaren wants to merge 1 commit intoAzureManagedRedis:mainfrom
Conversation
Add complete Infrastructure-as-Code conversion workflow for migrating Azure Cache for Redis (ACR) ARM/Bicep templates to Azure Managed Redis (AMR). - Core converter (Convert-AcrToAmr.ps1) with SKU mapping, clustering, persistence, networking, identity, and diagnostics support - E2E test runner with parallel ARM + Bicep WhatIf and real deploy validation - Shared helpers and validation script (Validate-Migration.ps1) - Template fixtures split by tier (Basic, Standard, Premium) - Private endpoint subnet.id fix with condition guard - RDB/AOF persistence parsing fallback for unresolvable redisConfiguration - Managed identity-based persistence support Test results: 239/239 unit tests, 13/13 WhatIf E2E (ARM + Bicep), 13/13 Bicep real deploy, 10/13 ARM real deploy (3 infra gaps, not code bugs) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
suryaren
force-pushed
the
users/suryar/iac-workflow
branch
from
3a91fcf to
66d863e
Compare
lolodi
reviewed
Mar 16, 2026
| [ordered]@{ | ||
| name = "redisEnterprise" | ||
| properties = [ordered]@{ | ||
| privateLinkServiceId = $DependsOnId.Replace("[resourceId(", "[resourceId(").Replace(")]", ")]") |
Contributor
There was a problem hiding this comment.
this seems to be replacing a string with the same one? Is it needed?
lolodi
reviewed
Mar 16, 2026
| # Can't resolve — return the reference as-is | ||
| return $Value | ||
| } | ||
| # Handle complex ARM expressions containing parameters('x') — e.g., [if(greater(parameters('shardCount'), 0), ...)] |
Contributor
There was a problem hiding this comment.
For expressions like [if(greater(parameters('shardCount'), 0), ...)], this returns the raw parameter value, not the expression result. Consider emitting a Write-Warning when this fallback triggers so users know to install PSRule for full resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a complete Infrastructure-as-Code conversion workflow for migrating Azure Cache for Redis (ACR) ARM/Bicep templates to Azure Managed Redis (AMR).
Changes
Convert-AcrToAmr.ps1): Parses ACR ARM/Bicep templates and produces equivalent AMR templates with correct SKU mapping, clustering, persistence, networking, identity, and diagnosticsValidate-Migration.ps1)Test Results