-
Notifications
You must be signed in to change notification settings - Fork 13
Add support to read mode from environment variables for aad subcommands #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mvanchaa would it be useful to measure how often the default auth mode isn't used? If the number is high, it might help us debug the circumstances in which the default auth mode isn't preferred. |
rewrlution
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments to this PR.
Done. |
|
More of a general comment for us to think about (and not something to take action on for this PR): I think we're starting to enter the territory where I believe AzureAuth is getting more complex than it should be. This PR, as well as at least one other we've made in the past, are adding changes to address issues that I believe ultimately stem from a problem with our broker auth flow. I think applying these workarounds to unblock customers is an absolutely valid path forward, but I also think we should start to assess why broker/WAM is consistently failing to auth silently for many of our customers. This doc even calls out that WAM is meant to be an even more effective way of retrieving tokens silently (over IWA which is not supported for Entra-backed "managed accounts"), and yet we're finding that the local MSAL cache and IWA (for service accounts) continue to work better for many of our customers. And the reality is that these flows are starting to be flagged as "non-compliant". I think it'd be a good idea for us to start looking at fixing our broker flow, and re-standardize our customers' auth flow towards the "compliant" solution. |
rewrlution
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
One hundred percent agreed! |
Why this change?
Some users are facing intermittent issues with broker mode while invoking build commands which internally invoke AzureAuth.
If they want to switch to a different mode, they need to change the build scripts and use the changed binaries which is not ideal and is difficult for the end user.
Hence, added this support, so that the user can set a mode that's not failing while we investigate the problem with the default mode.