Fix rule TA-000017 to allow TLS 1.3#396
Conversation
|
I was unable to assign this to myself. |
|
Added a new commit as I realised that rule TA-000011 (the functionApp variant of TA-000017) has the same issue. |
reynoldskr
left a comment
There was a problem hiding this comment.
@JohnathonMohr please also look, this should be fine.
JohnathonMohr
left a comment
There was a problem hiding this comment.
Thank you for your proactive contribution! This change will require good testing, as you can see from my comment about changing operators. You can add rule tests yourself, or this can wait until we have bandwidth to add them.
|
@microsoft-github-policy-service agree company="Redcentric" |
JohnathonMohr
left a comment
There was a problem hiding this comment.
This is looking really great, thank you! Just one extra request please.
src/Analyzer.Core.BuiltInRuleTests/Tests/TA-000017/AppServicesLatestTLSNoKind-Failures.bicep
Outdated
Show resolved
Hide resolved
|
Thanks for merging - when is the next release expected to be made? |
Description
Fix for #395
This PR updates TA-000017 to accept TLS 1.3 without reporting a violation.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines