Skip to content

Fix rule TA-000017 to allow TLS 1.3#396

Merged
JohnathonMohr merged 8 commits intoAzure:mainfrom
gazzyt:fix-tls-1_3
Jun 16, 2025
Merged

Fix rule TA-000017 to allow TLS 1.3#396
JohnathonMohr merged 8 commits intoAzure:mainfrom
gazzyt:fix-tls-1_3

Conversation

@gazzyt
Copy link
Contributor

@gazzyt gazzyt commented Jun 6, 2025

Description

Fix for #395

This PR updates TA-000017 to accept TLS 1.3 without reporting a violation.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • Description of the pull request is clear and informative.
  • I have added myself to the 'assignees'.
  • I have added 'linked issues' if relevant.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@gazzyt gazzyt requested a review from a team as a code owner June 6, 2025 11:27
@gazzyt
Copy link
Contributor Author

gazzyt commented Jun 6, 2025

I was unable to assign this to myself.
Rule TA-000017 has no unit tests

@gazzyt
Copy link
Contributor Author

gazzyt commented Jun 10, 2025

Added a new commit as I realised that rule TA-000011 (the functionApp variant of TA-000017) has the same issue.

Copy link

@reynoldskr reynoldskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnathonMohr please also look, this should be fine.

Copy link
Contributor

@JohnathonMohr JohnathonMohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your proactive contribution! This change will require good testing, as you can see from my comment about changing operators. You can add rule tests yourself, or this can wait until we have bandwidth to add them.

@gazzyt
Copy link
Contributor Author

gazzyt commented Jun 12, 2025

@microsoft-github-policy-service agree company="Redcentric"

Copy link
Contributor

@JohnathonMohr JohnathonMohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great, thank you! Just one extra request please.

@JohnathonMohr JohnathonMohr merged commit de6494b into Azure:main Jun 16, 2025
5 checks passed
@gazzyt
Copy link
Contributor Author

gazzyt commented Jun 17, 2025

Thanks for merging - when is the next release expected to be made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] AppServiceWebApp.UseLatestTLS does not recognise TLS 1.3

3 participants