Allow creating a template analyzer instance and load rules from memory#389
Merged
JohnathonMohr merged 12 commits intoAzure:mainfrom Feb 20, 2025
Merged
Conversation
reynoldskr
approved these changes
Feb 11, 2025
Contributor
JohnathonMohr
left a comment
JohnathonMohr
left a comment
There was a problem hiding this comment.
Just a couple style changes.
Co-authored-by: Johnathon Mohr <JohnathonMohr@users.noreply.github.com>
Co-authored-by: Johnathon Mohr <JohnathonMohr@users.noreply.github.com>
….com/borisf94/template-analyzer-ext into feature/borisf/allow_in_memory_rules
JohnathonMohr
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I add the ability to create a template analyzer instance and load the rules from memory.
We need to support rules provided from configuration that is read from a DB, meaning the rules are already in-memory as a string.
The PR is safe - the existing tests are covering all the capabilities as it only involves separating the existing logic into 2 methods.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines