Skip to content

fix: do not reconcile on imc status change #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanzhang-oss merged 2 commits into from
Jan 21, 2026

fix the code and add a bit clarification

728bfa9
Select commit
Loading
Failed to load commit list.
Merged

fix: do not reconcile on imc status change #351

fix the code and add a bit clarification
728bfa9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 21, 2026 in 0s

66.90% (-0.08%) compared to 20d3adf

View this Pull Request on Codecov

66.90% (-0.08%) compared to 20d3adf

Details

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.90%. Comparing base (20d3adf) to head (728bfa9).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...nternalmembercluster/v1beta1/controller_v1beta1.go 62.50% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   66.98%   66.90%   -0.08%     
==========================================
  Files          33       33              
  Lines        3786     3783       -3     
==========================================
- Hits         2536     2531       -5     
- Misses       1074     1077       +3     
+ Partials      176      175       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov